os-brick doesn't get installed on glance container venv when cinder is the default backend

Bug #1634497 reported by Kiriakos Krastillis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Jesse Pretorius

Bug Description

with a glance configuration of

```
glance_default_store: cinder
glance_additional_stores:
  - cinder
  - file

```

You get an error in the imports of cinder.py in https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/cinder.py doe to os_brick not being on the venv.

The glance_pip_packages variable in
https://github.com/openstack/openstack-ansible-os_glance/blob/stable/newton/defaults/main.yml#L199-L209 should therefore be dynamically expanded to include os-brick in case the cinder backend is set as the `glance_default_store` store or one of the `glance_additional_stores` stores.

Changed in openstack-ansible:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/388014

Changed in openstack-ansible:
assignee: nobody → Jesse Pretorius (jesse-pretorius)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_glance (master)

Reviewed: https://review.openstack.org/388014
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_glance/commit/?id=2c7d0e4dea602dfe94b3cbb0bd1a6be381d369e4
Submitter: Jenkins
Branch: master

commit 2c7d0e4dea602dfe94b3cbb0bd1a6be381d369e4
Author: Jesse Pretorius <email address hidden>
Date: Tue Oct 18 14:14:21 2016 +0100

    Add os-brick to glance_pip_packages

    In order to use cinder as a glance back-end, the os-brick
    python package is required.

    While the inclusion of the package could be dynamically
    included, we already have cinder listed as an additional
    back-end by default and the cost of including this library
    by default is minimal, so this opts to keep it simple and
    just always include it.

    The python package list is also sorted alphabetically for
    easier package name finding in the future.

    Change-Id: Id7e4638e1addf902e6027f6375c794fd56a5039d
    Closes-Bug: #1634497

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_glance (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/389305

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_glance (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/389306

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_glance (stable/newton)

Reviewed: https://review.openstack.org/389305
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_glance/commit/?id=22dfd3abb03c6143b273256931bc01bc849af1d6
Submitter: Jenkins
Branch: stable/newton

commit 22dfd3abb03c6143b273256931bc01bc849af1d6
Author: Jesse Pretorius <email address hidden>
Date: Tue Oct 18 14:14:21 2016 +0100

    Add os-brick to glance_pip_packages

    In order to use cinder as a glance back-end, the os-brick
    python package is required.

    While the inclusion of the package could be dynamically
    included, we already have cinder listed as an additional
    back-end by default and the cost of including this library
    by default is minimal, so this opts to keep it simple and
    just always include it.

    The python package list is also sorted alphabetically for
    easier package name finding in the future.

    Change-Id: Id7e4638e1addf902e6027f6375c794fd56a5039d
    Closes-Bug: #1634497
    (cherry picked from commit 2c7d0e4dea602dfe94b3cbb0bd1a6be381d369e4)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_glance 14.0.1

This issue was fixed in the openstack/openstack-ansible-os_glance 14.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_glance (stable/mitaka)

Reviewed: https://review.openstack.org/389306
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_glance/commit/?id=a37ff5b624e96a0e8b5c563bed3c4bef7498f5ad
Submitter: Jenkins
Branch: stable/mitaka

commit a37ff5b624e96a0e8b5c563bed3c4bef7498f5ad
Author: Jesse Pretorius <email address hidden>
Date: Tue Oct 18 14:14:21 2016 +0100

    Add os-brick to glance_pip_packages

    In order to use cinder as a glance back-end, the os-brick
    python package is required.

    While the inclusion of the package could be dynamically
    included, we already have cinder listed as an additional
    back-end by default and the cost of including this library
    by default is minimal, so this opts to keep it simple and
    just always include it.

    The python package list is also sorted alphabetically for
    easier package name finding in the future.

    Change-Id: Id7e4638e1addf902e6027f6375c794fd56a5039d
    Closes-Bug: #1634497
    (cherry picked from commit 2c7d0e4dea602dfe94b3cbb0bd1a6be381d369e4)

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_glance 14.0.1

This issue was fixed in the openstack/openstack-ansible-os_glance 14.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_glance 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_glance 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_glance 13.3.9

This issue was fixed in the openstack/openstack-ansible-os_glance 13.3.9 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.