OpenStack-Ansible

The rabbitmq deterministic sort is now pointless

Bug #1632831 reported by Jesse Pretorius
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Kevin Carter

Bug Description

While we've implemented a deterministic sort for rabbitmq hosts in order to try and spread the load, it is now pointless.

The rabbitmq drivers randomises the list give to it:

https://github.com/openstack/oslo.messaging/blob/4c67917484fc0944c87a163066bd62052f925095/oslo_messaging/_drivers/impl_rabbit.py#L513

playbooks/common-tasks/rabbitmq-servers-sort.yml and all references to it may as well be removed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386650

Changed in openstack-ansible:
assignee: nobody → Kevin Carter (kevin-carter)
status: New → In Progress
Kevin Carter (kevin-carter)
Changed in openstack-ansible:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/386650
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=144cfe9e7b3a5cfe58f67dfe0f81f61b2df0bd54
Submitter: Jenkins
Branch: master

commit 144cfe9e7b3a5cfe58f67dfe0f81f61b2df0bd54
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 09:50:29 2016 -0500

    Remove the rabbitmq deterministic sort

    This removes the rabbitmq deterministic sort common task. Due to
    upstream improvements in oslo this common task is no longer needed.

    Change-Id: I97c85f0c12b877927779dafa983ec1ce2afb5821
    Closes-Bug: #1632831
    Signed-off-by: Kevin Carter <email address hidden>

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387453

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/newton)

Reviewed: https://review.openstack.org/387453
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=fa21e2be66c6810c0125001fa7d3fca5faa68618
Submitter: Jenkins
Branch: stable/newton

commit fa21e2be66c6810c0125001fa7d3fca5faa68618
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 09:50:29 2016 -0500

    Remove the rabbitmq deterministic sort

    This removes the rabbitmq deterministic sort common task. Due to
    upstream improvements in oslo this common task is no longer needed.

    Conflicts:
    >------playbooks/os-trove-install.yml

    Change-Id: I97c85f0c12b877927779dafa983ec1ce2afb5821
    Closes-Bug: #1632831
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 144cfe9e7b3a5cfe58f67dfe0f81f61b2df0bd54)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.