OSA Horizon Role does not disable the Default Domain in multidomain set-up

[git-harry]

What is the expected behavior?

When setting horizon_keystone_multidomain_support to true, it should disable OPENSTACK_KEYSTONE_DEFAULT_DOMAIN in horizon_local_settings.py.

What is actually happening?

OPENSTACK_KEYSTONE_DEFAULT_DOMAIN is still specified and this prevents users from entering a domain name to use.

How can we reproduce this issue?

Launch an AIO. Edit /etc/openstack_deploy/user_variables.yml to include

horizon_keystone_multidomain_support: true

Downstream issue: https://github.com/rcbops/rpc-openstack/issues/1456

[Jean-Philippe Evrard (jean-philippe-evrard)]

I don't know anything about multi domain, but my expectation with this variable would be to add support of multi-domain.

The default domain should be specified by horizon_keystone_default_domain .

Would the questions be: May I disable the default domain if horizon_keystone_default_domain is set to ''? Should I do it that way?

Currently we have this in our templating:
OPENSTACK_KEYSTONE_DEFAULT_DOMAIN = "{{ horizon_keystone_default_domain }}"

Maybe we should move to
{% if horizon_keystone_default_domain | length > 0 %}
OPENSTACK_KEYSTONE_DEFAULT_DOMAIN = "{{ horizon_keystone_default_domain }}"
{% %}

Would that be a proper fix?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/386753

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/386753
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_horizon/commit/?id=92d57b525e2c756d713ad5a3fd5f0f1f325cf9f9
Submitter: Jenkins
Branch: master

commit 92d57b525e2c756d713ad5a3fd5f0f1f325cf9f9
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 14:31:35 2016 -0500

    Add conditional for multi-domain support

    When running a multi-domain cloud the constant
    "OPENSTACK_KEYSTONE_DEFAULT_DOMAIN" needs to be omitted from the
    rendered "local_setting.py" file. This change keys off of the
    "horizon_keystone_multidomain_support" value and should it be `true`
    the constant "OPENSTACK_KEYSTONE_DEFAULT_DOMAIN" will be omitted from
    config.

    Closes-Bug: #1629865
    Change-Id: I81c5d17bfd4d946567a49db9adfb4285d05303c3
    Signed-off-by: Kevin Carter <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387427

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/387427
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_horizon/commit/?id=0001eade2c298dc201eb802a2e018dc765fb923b
Submitter: Jenkins
Branch: stable/newton

commit 0001eade2c298dc201eb802a2e018dc765fb923b
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 14:31:35 2016 -0500

    Add conditional for multi-domain support

    When running a multi-domain cloud the constant
    "OPENSTACK_KEYSTONE_DEFAULT_DOMAIN" needs to be omitted from the
    rendered "local_setting.py" file. This change keys off of the
    "horizon_keystone_multidomain_support" value and should it be `true`
    the constant "OPENSTACK_KEYSTONE_DEFAULT_DOMAIN" will be omitted from
    config.

    Closes-Bug: #1629865
    Change-Id: I81c5d17bfd4d946567a49db9adfb4285d05303c3
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 92d57b525e2c756d713ad5a3fd5f0f1f325cf9f9)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon 14.0.0.0rc4 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon 15.0.0.0b1 development milestone.