pip-conf-removal.yml doesnt remove the older repo on all the containers

[seetha]

pip-conf-removal.yml doesnt remove the older repo on all the containers. Right now the groups include only the hosts and containers. Upgrade from Liberty to Mitaka fails since it has the old pip.conf.

hosts: hosts:repo_all

[Jimmy McCrory (jimmy-mccrory)]

Still working on reproducing this, but I think I see the logic where this might be needed or the role needs improvement.

The playbook installs the pip_lock_down role.
https://github.com/openstack/openstack-ansible/blob/stable/mitaka/playbooks/galera-install.yml#L66

pip_lock_down depends on pip_install, so that's run first.
https://github.com/openstack/openstack-ansible-pip_lock_down/blob/stable/mitaka/meta/main.yml#L32

The last task in pip_install installs pip_required_pip_packages, which includes packages newly added to the Mitaka release.
https://github.com/openstack/openstack-ansible-pip_install/blob/stable/mitaka/tasks/main.yml#L124
https://github.com/openstack/openstack-ansible-pip_install/blob/stable/mitaka/defaults/main.yml#L46

pip_required_pip_packages are only installed with the isolated flag if pip_packages needed to be installed that way.

So if the required versions of pip_packages are available, the fall back task isn't required and the "Install pip packages" task will fail.

Which tagged releases were used for Liberty and Mitaka?

[seetha (munnangi2010)]

Hi Jimmy,

Liberty - 12.0.14
Mitaka - 13.3.3

[Jean-Philippe Evrard (jean-philippe-evrard)]

We'd probably need to implement the same fallback logic as here:
https://github.com/openstack/openstack-ansible-pip_install/blob/stable/mitaka/tasks/main.yml#L107-118

for the last task.
If all the packages are in the repo, that's fine, else fallback to isolated.

That's what you meant Jimmy?

[Jean-Philippe Evrard (jean-philippe-evrard)]

It sounds better than passing a flag --isolated in the upgrade process.

[Jimmy McCrory (jimmy-mccrory)]

Yeah, I think so.

master/newton works differently, pip.conf is updated/locked down before trying to install these packages.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/384355

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/384355
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=c03d6a6d464ed702e1662a5ebbd67d50fc5fb34d
Submitter: Jenkins
Branch: master

commit c03d6a6d464ed702e1662a5ebbd67d50fc5fb34d
Author: Jesse Pretorius <email address hidden>
Date: Mon Oct 10 09:35:57 2016 +0100

    Ensure that package installs can fall back

    Currently the package installs only fall back if the pip
    installs needed to. During upgrades from environments
    where there are the right versions of pip, setuptools
    and wheel in the repo, but there aren't yet the right
    packages for the package install this method will fail.

    This ensures that the fall back install for the packages
    is decoupled from the fall back for the pip install.

    Change-Id: Id855319bbab5ff6bc3b539ebedc495a5bc12afd1
    Closes-Bug: #1627174

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/384966

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/384969

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/384966
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=cdbe43fabe517ef14d2d9e30389a576295084383
Submitter: Jenkins
Branch: stable/newton

commit cdbe43fabe517ef14d2d9e30389a576295084383
Author: Jesse Pretorius <email address hidden>
Date: Mon Oct 10 09:35:57 2016 +0100

    Ensure that package installs can fall back

    Currently the package installs only fall back if the pip
    installs needed to. During upgrades from environments
    where there are the right versions of pip, setuptools
    and wheel in the repo, but there aren't yet the right
    packages for the package install this method will fail.

    This ensures that the fall back install for the packages
    is decoupled from the fall back for the pip install.

    Change-Id: Id855319bbab5ff6bc3b539ebedc495a5bc12afd1
    Closes-Bug: #1627174
    (cherry picked from commit c03d6a6d464ed702e1662a5ebbd67d50fc5fb34d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/384969
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=2eba5f900311531f5c1d8a93e490124b04349cd0
Submitter: Jenkins
Branch: stable/mitaka

commit 2eba5f900311531f5c1d8a93e490124b04349cd0
Author: Jesse Pretorius <email address hidden>
Date: Tue Oct 11 13:16:36 2016 +0100

    Ensure that package installs can fall back

    Currently the package installs only fall back if the pip
    installs needed to. During upgrades from environments
    where there are the right versions of pip, setuptools
    and wheel in the repo, but there aren't yet the right
    packages for the package install this method will fail.

    This ensures that the fall back install for the packages
    is decoupled from the fall back for the pip install.

    Re-implementation of https://review.openstack.org/384355
    due to a complete re-organisation of the role's tasks
    from Newton onwards.

    Change-Id: Id855319bbab5ff6bc3b539ebedc495a5bc12afd1
    Closes-Bug: #1627174

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/385370

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/385370
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=0d824ce48db89e872caca5e579152caf3a79f005
Submitter: Jenkins
Branch: stable/newton

commit 0d824ce48db89e872caca5e579152caf3a79f005
Author: Jesse Pretorius <email address hidden>
Date: Wed Oct 12 10:46:05 2016 +0100

    Update role SHAs for 14.0.0 2016-10-12

    Related-Bug: #1627174
    Related-Bug: #1631158
    Related-Bug: #1630950
    Related-Bug: #1630953
    Related-Bug: #1631362
    Closes-Bug: #1631922
    Closes-Bug: #1631924
    Closes-Bug: #1631927

    Change-Id: I3657bf31136b5d00931bedc8c7cd7109a31c5c5f

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-pip_install 14.0.0.0rc3 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-pip_install 13.3.6 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-pip_install 15.0.0.0b1 development milestone.