os_ironic mysql password variable not updated

Bug #1625081 reported by Michael Davies
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Jesse Pretorius

Bug Description

Ironic in OSA is currently broken as the ironic database user isn't created, and consequently the ironic services can't connect to the database.

The root cause of this is that back in commit https://github.com/openstack/openstack-ansible/commit/91deb13ec21b0402fd3781df46f38fbbcd66a963 we standardised on common OSA tasks, and part of that was changing from 'ironic_galera_password' to 'ironic_container_mysql_password' for the ironic galera database password, but we didn't update the rest of openstack-ansible for this change.

Michael Davies (mrda)
Changed in openstack-ansible:
assignee: nobody → Michael Davies (mrda)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/372346

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/372355

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/372346
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=6e50d69b22ae57a98fc0a93688f923398c41b1c6
Submitter: Jenkins
Branch: master

commit 6e50d69b22ae57a98fc0a93688f923398c41b1c6
Author: Michael Davies <email address hidden>
Date: Mon Sep 19 19:07:44 2016 +0930

    os_ironic mysql password variable not updated

    Ironic in OSA is currently broken as the ironic database
    user isn't created, and consequently the ironic services can't
    connect to the database. It broke back in patch 91deb13.

    This patch corrects the openstack-ansible side of the problem.
    Another patch will fix the os-ironic side.

    Change-Id: I38aa44bc33a80bb6d53a66bce34aff57048a1af3
    Partial-Bug: #1625081
    Signed-off-by: Michael Davies <email address hidden>

Changed in openstack-ansible:
assignee: Michael Davies (mrda) → Jesse Pretorius (jesse-pretorius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_ironic (master)

Reviewed: https://review.openstack.org/372355
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ironic/commit/?id=f24f266208b8c479a0c389d66a43a83d9b749591
Submitter: Jenkins
Branch: master

commit f24f266208b8c479a0c389d66a43a83d9b749591
Author: Michael Davies <email address hidden>
Date: Mon Sep 19 19:20:33 2016 +0930

    os_ironic mysql password variable not updated

    Ironic in OSA is currently broken as the ironic database
    user isn't created, and consequently the ironic services can't
    connect to the database. It broke back in patch 91deb13.

    This patch corrects the os_ironic side of the problem. Another
    patch will fix the openstack-ansible side.

    Change-Id: I30b04756258a3241bb2444fd98f3a6624c0d2309
    Partial-Bug: #1625081
    Signed-off-by: Michael Davies <email address hidden>

Revision history for this message
Jesse Pretorius (jesse-pretorius) wrote :

It would seem that the only outstanding item here would be to ensure that the variable is appropriately converted when doing an upgrade from Mitaka to Newton.

Changed in openstack-ansible:
assignee: Jesse Pretorius (jesse-pretorius) → nobody
status: In Progress → Confirmed
Changed in openstack-ansible:
assignee: nobody → Jimmy McCrory (jimmy-mccrory)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/383486

Changed in openstack-ansible:
status: Confirmed → In Progress
Changed in openstack-ansible:
assignee: Jimmy McCrory (jimmy-mccrory) → Jesse Pretorius (jesse-pretorius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/383486
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=57255a164d580666b94d50bdd7cd906fa8a919d2
Submitter: Jenkins
Branch: master

commit 57255a164d580666b94d50bdd7cd906fa8a919d2
Author: Jimmy McCrory <email address hidden>
Date: Thu Oct 6 14:31:01 2016 -0700

    Rename ironic database password during upgrades

    'ironic_galera_password' was renamed to
    'ironic_container_mysql_password' in change
    I399211c139d6388ab56b97b809f93d4936907c7a.

    Update the user-secrets-adjustment upgrade playbook to handle renaming
    within the user's secrets file and ensure that the original value is
    kept.

    Change-Id: Idca153bc474b415316ce59a5e7068d030af81fe9
    Closes-Bug: 1625081

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/383927

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/newton)

Reviewed: https://review.openstack.org/383927
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=5aee4a3916e7dfb4ef6189b8f7a1554c56aa6a77
Submitter: Jenkins
Branch: stable/newton

commit 5aee4a3916e7dfb4ef6189b8f7a1554c56aa6a77
Author: Jimmy McCrory <email address hidden>
Date: Thu Oct 6 14:31:01 2016 -0700

    Rename ironic database password during upgrades

    'ironic_galera_password' was renamed to
    'ironic_container_mysql_password' in change
    I399211c139d6388ab56b97b809f93d4936907c7a.

    Update the user-secrets-adjustment upgrade playbook to handle renaming
    within the user's secrets file and ensure that the original value is
    kept.

    Change-Id: Idca153bc474b415316ce59a5e7068d030af81fe9
    Closes-Bug: 1625081
    (cherry picked from commit 57255a164d580666b94d50bdd7cd906fa8a919d2)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 14.0.0.0rc3

This issue was fixed in the openstack/openstack-ansible 14.0.0.0rc3 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.