Upgrade failing due to not finding the osa_secrets_file_name variable when running the user-secrets-adjustment.yml playbook

[Castulo J. Martinez]

When running the run_upgrade.sh script for upgrading from stable/mitaka to master the upgrade is failing with this error message:

The error appears to have been in '/opt/openstack-ansible/scripts/upgrade-utilities/playbooks/user-secrets-adjustment.yml': line 25, column 7, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

      register: secrets
    - name: Add missing secret
      ^ here
"}

msg: the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'osa_secrets_file_name' is undefined

Apparently, the osa_secrets_file_name variable that is defined in the openstack/openstack-ansible/blob/master/scripts/upgrade-utilities/playbooks/defaults/main.yml playbook is not being found.

This seems to be related to this change:
https://github.com/openstack/openstack-ansible/commit/bceb1e15e61af8f996831f54477e840d123522f8

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/370981

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370981
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=2ec74e9d8a012673bdad9343e5f9931f89bb8faa
Submitter: Jenkins
Branch: master

commit 2ec74e9d8a012673bdad9343e5f9931f89bb8faa
Author: Matthew Thode <email address hidden>
Date: Thu Sep 15 11:24:48 2016 -0500

    load variables as a simple var for upgrades

    This is needed because the upgrade.sh script runs each task on it's own.
    Not as a natural play. extra vars (as defined automaticly via the
    openstack-ansible command) still take precidence.

    Change-Id: I86c95d3fb6f9d931093ff6622b25e814920940f6
    Closes-Bug: 1624029

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/371228

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371228
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=42b2a79c816f289060a0abd35d3ef3924eb46852
Submitter: Jenkins
Branch: stable/mitaka

commit 42b2a79c816f289060a0abd35d3ef3924eb46852
Author: Matthew Thode <email address hidden>
Date: Thu Sep 15 11:24:48 2016 -0500

    load variables as a simple var for upgrades

    This is needed because the upgrade.sh script runs each task on it's own.
    Not as a natural play. extra vars (as defined automaticly via the
    openstack-ansible command) still take precidence.

    Change-Id: I86c95d3fb6f9d931093ff6622b25e814920940f6
    Closes-Bug: 1624029
    (cherry picked from commit 2ec74e9d8a012673bdad9343e5f9931f89bb8faa)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 13.3.4 release.