lxc-veth-check wires veth pairs incorrectly

Bug #1617131 reported by Paulo Matias
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Paulo Matias

Bug Description

After accidentally wiping up all veth pairs wired to br-mgmt (by doing an ifdown br-mgmt), I ran /usr/local/bin/lxc-veth-check in order to create them again.

Per my config, the eth1 interface from all containers should be wired to br-mgmt. However, as the script greps for the corresponding config file, it happens to find the one for eth10 instead of eth1:

---
controller-03_neutron_agents_container-6c550730 had a broken veth 6c550730_eth1 not being plugged into br-vxlan: this issue is now resolved
---

It might also find configs for eth11 or eth12 because both contain the string "eth1".

Therefore, the grep below should be modified to check for a word boundary.

grep -l "${net_info}" /var/lib/lxc/${container}/{config,*.ini}

I will submit a patch to gerrit right now.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-lxc_hosts (master)

Fix proposed to branch: master
Review: https://review.openstack.org/360860

Changed in openstack-ansible:
assignee: nobody → Paulo Matias (paulo-matias)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-lxc_hosts (master)

Reviewed: https://review.openstack.org/360860
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_hosts/commit/?id=dcf4ba7de84a5ef3cd302a2969eaa2f93d34183f
Submitter: Jenkins
Branch: master

commit dcf4ba7de84a5ef3cd302a2969eaa2f93d34183f
Author: Paulo Matias <email address hidden>
Date: Fri Aug 26 00:02:31 2016 -0300

    Check for word boundaries around net interface name

    Closes-Bug: #1617131
    Change-Id: I9b962e2018173564eb0c35f88f16150944a08882

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible-lxc_hosts 14.0.0.0b3

This issue was fixed in the openstack/openstack-ansible-lxc_hosts 14.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.