swift_rings_distribute.yml synchronize task broken on multi-node

[Miguel Alejandro Cantu]

The synchronize module in swift_rings_distribute.yml[1] seems to be broken with the ansible version that's shipping with the current master branch(v2.1.0). See error here [2]
Seems to be a problem with the combination of "become_user", "delegate_to", and the way the synchronize module runs the rsync command. The --rsync-path looks suspicious to me. Why is it "sudo rsync" when we are escalating privileges to the swift user via "become_user"?

This error will not appear in an AIO build, most likely due to the fact that the AIO doesn't have problems with connecting to itself via root user.

[1] https://github.com/openstack/openstack-ansible-os_swift/blob/master/tasks/swift_rings_distribute.yml
[2] https://gist.github.com/alextricity25/20c7045737324f4cc991864fd8ba1f65

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/336624
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_swift/commit/?id=2ba929f1729021afa18143b2fdd5771b5c4876fa
Submitter: Jenkins
Branch: master

commit 2ba929f1729021afa18143b2fdd5771b5c4876fa
Author: Kevin Carter <email address hidden>
Date: Fri Jul 1 10:40:42 2016 -0500

    Fix swift ring distribute

    The swift ring distribute task was using the Synchronize module
    which is broken in ansible 2.1 when using become and delegate_to.
    The become and delegate_to methods are required to make the module
    pull from a remote source to another remote source using a specific
    user. To resolve the issue these tasks have been changed to use the
    command module.

    Related-Issue: https://github.com/ansible/ansible/issues/15405

    Change-Id: I1f0a14759408e3efd066a8adf4510db688d01437
    Closes-bug: #1597475
    Signed-off-by: Kevin Carter <email address hidden>

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible-os_swift 14.0.0.0b2 development milestone.