check_mode not set when using tags with security role

Bug #1590086 reported by Major Hayden on 2016-06-07
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
openstack-ansible
High
Major Hayden

Bug Description

If a tag is provided with the security role in check mode, the check_mode variable is not set. This causes any tasks that depend on that variable to fail.

Fix proposed to branch: master
Review: https://review.openstack.org/326664

Changed in openstack-ansible:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/326664
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-security/commit/?id=d8ae1e3b04550f271d5561430a9008dee1cf4187
Submitter: Jenkins
Branch: master

commit d8ae1e3b04550f271d5561430a9008dee1cf4187
Author: Major Hayden <email address hidden>
Date: Tue Jun 7 13:05:49 2016 -0500

    Set check_mode variable every time

    In check mode, the security role will fail when tags are used. This
    is because the check_mode variable wasn't being set when tags were
    provided. This patch ensures that the tasks that check for check mode
    and set the subsequent check_mode variable will run every time.

    Closes-bug: 1590086

    Change-Id: Ib6a29ee4c36632cd6d982ce87105f0ddec4a891d

Changed in openstack-ansible:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/327657
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-security/commit/?id=f0848de629f9e9e595749ceef727ef53693f624d
Submitter: Jenkins
Branch: stable/mitaka

commit f0848de629f9e9e595749ceef727ef53693f624d
Author: Major Hayden <email address hidden>
Date: Thu Jun 9 08:19:27 2016 -0500

    Set check_mode variable every time

    In check mode, the security role will fail when tags are used. This
    is because the check_mode variable wasn't being set when tags were
    provided. This patch ensures that the tasks that check for check mode
    and set the subsequent check_mode variable will run every time.

    This is a manual backport of Ib6a29ee4c36632cd6d982ce87105f0ddec4a891d
    since the master/Newton branch includes some new things for systemd that
    doesn't make sense in Mitaka/Liberty.

    Closes-bug: 1590086

    Change-Id: Ib6a29ee4c36632cd6d982ce87105f0ddec4a891d

tags: added: in-stable-mitaka
tags: added: in-liberty

Reviewed: https://review.openstack.org/327658
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-security/commit/?id=6213c87d51d00416475e1e97c13686e726c8f288
Submitter: Jenkins
Branch: liberty

commit 6213c87d51d00416475e1e97c13686e726c8f288
Author: Major Hayden <email address hidden>
Date: Thu Jun 9 08:19:27 2016 -0500

    Set check_mode variable every time

    In check mode, the security role will fail when tags are used. This
    is because the check_mode variable wasn't being set when tags were
    provided. This patch ensures that the tasks that check for check mode
    and set the subsequent check_mode variable will run every time.

    This is a manual backport of Ib6a29ee4c36632cd6d982ce87105f0ddec4a891d
    since the master/Newton branch includes some new things for systemd that
    doesn't make sense in Mitaka/Liberty.

    Closes-bug: 1590086

    Change-Id: Ib6a29ee4c36632cd6d982ce87105f0ddec4a891d

This issue was fixed in the openstack/openstack-ansible-security 13.1.4 release.

This issue was fixed in the openstack/openstack-ansible-security 12.0.16 release.

This issue was fixed in the openstack/openstack-ansible-security 14.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers