horizon_developer_mode does not work

[Darren Birkett]

When enabling horizon_developer_mode the ansible run fails due to unmet requirements:

# openstack-ansible os-horizon-install.yml -e horizon_developer_mode=true

--- some output ---

failed: [aio1_horizon_container-044f3b5a] => (item=python-keystoneclient) => {"attempts": 5, "cmd": "/usr/local/bin/pip install -U --constraint /opt/developer-pip-constraints.txt --constraint /opt/requirements/upper-constraints.txt python-keystoneclient", "failed": true, "item": "python-keystoneclient"}
msg: Task failed as maximum retries was encountered

cmd:
/usr/local/bin/pip install -U --constraint /opt/developer-pip-constraints.txt --constraint /opt/requirements/upper-constraints.txt python-keystoneclient

--- some more output ---

Running the command manually inside the container:

# /usr/local/bin/pip install -U --constraint /opt/developer-pip-constraints.txt --constraint /opt/requirements/upper-constraints.txt python-keystoneclient
Ignoring indexes: https://pypi.python.org/simple
Ignoring dnspython3: markers u"python_version=='3.4'" don't match your environment
Ignoring ovs: markers u"python_version=='3.4'" don't match your environment
Collecting python-keystoneclient===3.1.0 (from -c /opt/requirements/upper-constraints.txt (line 292))
  Could not find a version that satisfies the requirement python-keystoneclient===3.1.0 (from -c /opt/requirements/upper-constraints.txt (line 292)) (from versions: 3.0.0)
No matching distribution found for python-keystoneclient===3.1.0 (from -c /opt/requirements/upper-constraints.txt (line 292))

This is using osa master branch. I'm guessing for some reason the horizon constraints file is not being considered when package versions are resolved in repo build?

[Jimmy McCrory (jimmy-mccrory)]

developer mode will default to the current master branch of openstack/requirements to look for upper constraints:
https://github.com/openstack/openstack-ansible-os_horizon/blob/master/defaults/main.yml#L23

repo_build will use this given SHA:
https://github.com/openstack/openstack-ansible/blob/master/playbooks/defaults/repo_packages/openstack_services.yml#L58

The python-keystoneclient upper constraint was bumped in a commit after the current OSA SHA which is why the package is missing. https://review.openstack.org/#/c/319069/

-e pip_install_options="--isolated" will work, but I'm thinking that might be good to include directly in the role's fact when developer_mode is set.
https://github.com/openstack/openstack-ansible-os_horizon/blob/master/tasks/horizon_install.yml#L50

That would also help work around a locked down pip.conf and avoid the role dependency/variable needed to lock that file down.

[Jean-Philippe Evrard (jean-philippe-evrard)]

Ruled in favor of simply using '-e pip_install_options="--isolated"' to make this work, or use the developer mode in a standard way.

Thanks for your bug!