nofile settings missing for memcached_server role

Bug #1582288 reported by Bjoern
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Bjoern

Bug Description

I noticed that we can increase the limits of connections within memcached but do not configure the actual nofile limit, which ultimately will cause memcached crashes.
I like to back port this issues into all open branches

Bjoern (bjoern-t)
Changed in glance:
assignee: nobody → Bjoern Teipel (bjoern-teipel)
summary: - Ulimit settings missign for memcached_server role
+ Ulimit settings missing for memcached_server role
summary: - Ulimit settings missing for memcached_server role
+ nofile settings missing for memcached_server role
Revision history for this message
Bjoern (bjoern-t) wrote :

Proposed review for master: https://review.openstack.org/#/c/317030/

affects: glance → openstack-ansible
Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-memcached_server (master)

Reviewed: https://review.openstack.org/317030
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-memcached_server/commit/?id=5c2d8c55ec51bee993d134aa9d4484879b762d62
Submitter: Jenkins
Branch: master

commit 5c2d8c55ec51bee993d134aa9d4484879b762d62
Author: Bjoern Teipel <email address hidden>
Date: Mon May 16 11:48:53 2016 -0500

    Configure nofile OS limit for memcached server role

    This fix adds a new override `memcached_connections` which is
    automatically calculated from the number of memcached
    connection limit plus additional 1k to configure the OS nofile limit.
    Without proper nofile limit configuration, memcached will crash
    in order to support higher parallel connection TCP/Memcache counts.

    Closes-Bug: #1582288

    Change-Id: I558ba329b7247cdfcf660e392c3ae0c4a0d65a53

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-memcached_server (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/319267

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (liberty)

Fix proposed to branch: liberty
Review: https://review.openstack.org/319280

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-memcached_server (stable/mitaka)

Reviewed: https://review.openstack.org/319267
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-memcached_server/commit/?id=045b2d8f544bc563372c9d82cee94789abf3d3bb
Submitter: Jenkins
Branch: stable/mitaka

commit 045b2d8f544bc563372c9d82cee94789abf3d3bb
Author: Bjoern Teipel <email address hidden>
Date: Mon May 16 11:48:53 2016 -0500

    Configure nofile OS limit for memcached server role

    This fix adds a new override `memcached_connections` which is
    automatically calculated from the number of memcached
    connection limit plus additional 1k to configure the OS nofile limit.
    Without proper nofile limit configuration, memcached will crash
    in order to support higher parallel connection TCP/Memcache counts.

    Closes-Bug: #1582288

    Change-Id: I558ba329b7247cdfcf660e392c3ae0c4a0d65a53
    (cherry picked from commit 5c2d8c55ec51bee993d134aa9d4484879b762d62)

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (liberty)

Reviewed: https://review.openstack.org/319280
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=a9185101a37cdf21c08fb95dbff1010e24128888
Submitter: Jenkins
Branch: liberty

commit a9185101a37cdf21c08fb95dbff1010e24128888
Author: Bjoern Teipel <email address hidden>
Date: Fri May 20 09:27:53 2016 -0500

    Configure nofile OS limit for memcached server role

    This fix adds a new override `memcached_connections` which is
    automatically calculated from the number of memcached
    connection limit plus additional 1k to configure the OS nofile limit.
    Without proper nofile limit configuration, memcached will crash
    in order to support higher parallel connection TCP/Memcache counts.

    Related-To: https://review.openstack.org/#/c/317030/

    Change-Id: Ib9a3a5fdf567e6024819ebcfd574a5d1d15e5e23
    Closes-Bug: #1582288

tags: added: in-liberty
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible-memcached_server 13.1.2

This issue was fixed in the openstack/openstack-ansible-memcached_server 13.1.2 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 12.0.14

This issue was fixed in the openstack/openstack-ansible 12.0.14 release.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/openstack-ansible-memcached_server 14.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-memcached_server 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.