handle_internal_only_routers hard-coded to False in v12+

[James Denton]

In the Kilo l3_agent.ini template, handle_internal_only_routers is an override-able option (defaults to True):

https://github.com/openstack/openstack-ansible/blob/kilo/playbooks/roles/os_neutron/templates/l3_agent.ini.j2#L34

handle_internal_only_routers = {{ neutron_handle_internal_only_routers }}

In v12+, it appears to be hard-coded to False:

https://github.com/openstack/openstack-ansible/blob/liberty/playbooks/roles/os_neutron/templates/l3_agent.ini.j2#L28

handle_internal_only_routers = False

In addition, the option has been removed from the defaults:
https://github.com/openstack/openstack-ansible/blob/liberty/playbooks/roles/os_neutron/defaults/main.yml

Please allow this to be overriden.

Related: https://bugs.launchpad.net/neutron/+bug/1572390

[Bjoern (bjoern-t)]

We stopped adding overrides in favor of using generic overrides via neutron_l3_agent_ini_overrides
See more info at https://github.com/openstack/openstack-ansible/blob/master/doc/source/install-guide/configure-openstack.rst

[Bjoern (bjoern-t)]

Review submitted for master branch.

[Bjoern (bjoern-t)]

  https://review.openstack.org/312231

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/312231
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_neutron/commit/?id=c15dcba878101b4047dd3141dd52444979a75692
Submitter: Jenkins
Branch: master

commit c15dcba878101b4047dd3141dd52444979a75692
Author: Bjoern Teipel <email address hidden>
Date: Tue May 3 15:05:26 2016 -0500

    Use upstream neutron default for handle_internal_only_routers

    The configuration for the variable handle_internal_only_routers
    is removed in order to use the Neutron upstream default setting.
    The current default for handle_internal_only_routers is True,
    which does allow Neutron L3 router without external networks
    attached (as discussed per https://bugs.launchpad.net/neutron/+bug/1572390)

    Change-Id: I78bd4216bb459224df2a5cd67f344732ea5d1214
    Closes-Bug: #1577868

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/openstack-ansible-os_neutron 14.0.0.0b1 development milestone.