role openstack_hosts fails not to add scsi_dh to /etc/modules

[Jirayut Nimsaeng]

I got this error

<172.29.236.100> ESTABLISH CONNECTION FOR USER: root
<172.29.236.100> REMOTE_MODULE modprobe name=nf_nat
<172.29.236.100> EXEC ssh -C -vvv -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/root/.ansible/cp/ansible-ssh-%h-%p-%r" -o StrictHostKeyChecking=no -o KbdInteractiveAuthentication=no -o Pref
erredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=120 172.29.236.100 /bin/sh -c 'LANG=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 /usr/bin/python'
ok: [aio1] => (item=nf_nat) => {"changed": false, "failed": false, "item": "nf_nat", "name": "nf_nat", "params": "", "state": "present"}
<172.29.236.100> ESTABLISH CONNECTION FOR USER: root
<172.29.236.100> REMOTE_MODULE modprobe name=nf_nat_ipv4
<172.29.236.100> EXEC ssh -C -vvv -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/root/.ansible/cp/ansible-ssh-%h-%p-%r" -o StrictHostKeyChecking=no -o KbdInteractiveAuthentication=no -o Pref
erredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=120 172.29.236.100 /bin/sh -c 'LANG=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 /usr/bin/python'
ok: [aio1] => (item=nf_nat_ipv4) => {"changed": false, "failed": false, "item": "nf_nat_ipv4", "name": "nf_nat_ipv4", "params": "", "state": "present"}
<172.29.236.100> ESTABLISH CONNECTION FOR USER: root
<172.29.236.100> REMOTE_MODULE modprobe name=''
<172.29.236.100> EXEC ssh -C -vvv -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/root/.ansible/cp/ansible-ssh-%h-%p-%r" -o StrictHostKeyChecking=no -o KbdInteractiveAuthentication=no -o Pref
erredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=120 172.29.236.100 /bin/sh -c 'LANG=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 /usr/bin/python'
failed: [aio1] => {"changed": false, "failed": true, "item": "", "name": "", "params": "", "state": "present"}
msg: modprobe: FATAL: Module not found in directory /lib/modules/4.4.0-21-generic

<172.29.236.100> ESTABLISH CONNECTION FOR USER: root
<172.29.236.100> REMOTE_MODULE modprobe name=vhost_net
<172.29.236.100> EXEC ssh -C -vvv -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/root/.ansible/cp/ansible-ssh-%h-%p-%r" -o StrictHostKeyChecking=no -o KbdInteractiveAuthentication=no -o Pref
erredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=120 172.29.236.100 /bin/sh -c 'LANG=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 /usr/bin/python'
ok: [aio1] => (item=vhost_net) => {"changed": false, "failed": false, "item": "vhost_net", "name": "vhost_net", "params": "", "state": "present"}
<172.29.236.100> ESTABLISH CONNECTION FOR USER: root
<172.29.236.100> REMOTE_MODULE modprobe name=x_tables
<172.29.236.100> EXEC ssh -C -vvv -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/root/.ansible/cp/ansible-ssh-%h-%p-%r" -o StrictHostKeyChecking=no -o KbdInteractiveAuthentication=no -o Pref
erredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o ConnectTimeout=120 172.29.236.100 /bin/sh -c 'LANG=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 /usr/bin/python'
ok: [aio1] => (item=x_tables) => {"changed": false, "failed": false, "item": "x_tables", "name": "x_tables", "params": "", "state": "present"}

I suspected that this line causing the problem
https://github.com/openstack/openstack-ansible-openstack_hosts/blob/master/defaults/main.yml#L60

When I'm using kernel version more than 4.4.0-0-generic. It will leave this line to be blank with dash and the problem occurs.
If we can we should add test to test this kind of problem too but I still have no idea how to test it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/309796

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309796
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=ada466cccd8a55f6ed43ad2f3bc75a0a72bdbd77
Submitter: Jenkins
Branch: master

commit ada466cccd8a55f6ed43ad2f3bc75a0a72bdbd77
Author: Jirayut Nimsaeng <email address hidden>
Date: Sun Apr 24 22:54:24 2016 +0700

    Fix error by add condition to check if item is empty from the conditional

    Change-Id: I20ec56279fb774fc411251cc89e1a685a6a7c5e7
    Closes-Bug: #1573908

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/openstack-ansible-openstack_hosts 14.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/336628

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/336628
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=27dc86485a1d3873a6d2392a24bcfea965f1823a
Submitter: Jenkins
Branch: stable/mitaka

commit 27dc86485a1d3873a6d2392a24bcfea965f1823a
Author: Jirayut Nimsaeng <email address hidden>
Date: Sun Apr 24 22:54:24 2016 +0700

    Fix error by add condition to check if item is empty from the conditional

    Change-Id: I20ec56279fb774fc411251cc89e1a685a6a7c5e7
    Closes-Bug: #1573908
    (cherry picked from commit ada466cccd8a55f6ed43ad2f3bc75a0a72bdbd77)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible-openstack_hosts 13.3.0 release.