sysstat.default.j2 should convert true and false to lower case

Bug #1546796 reported by gdahlman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
New
Undecided
Unassigned

Bug Description

openstack-ansible/playbooks/roles/openstack_hosts/templates/sysstat.default.j2 in the liberty tagged versions like 12.0.5 will write

ENABLED="True" which is evaluated as not matching true thus is considered a false.

While it could be fixed in the config file it is probably better to just add the lower jinja filter

It is currently:

ENABLED="{{ openstack_host_systat_enabled }}"

should be changed to:

ENABLED="{{ openstack_host_systat_enabled | lower }}"

Revision history for this message
Ala Raddaoui (raddaoui-ala) wrote :

gdahlman, I checked version 12.0.5 and previous versions and they all have default value
openstack_host_systat_enabled: true
with a comment saying that Valid values are "true" and "false".

can you explain further the problem?

Revision history for this message
Hector Gonzalez (theizaakk) wrote :

I think the problem is when the template is generated by Jinja, It's related to this bug:

https://bugs.launchpad.net/openstack-ansible/+bug/1530979

The fix has been commited to master, but in the galaxy repo.

I'm working on backporitng this fix.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.