dynamic_inventory "container"_cidr strongly typed

[Miguel Alejandro Cantu]

The dynamic_inventory.py script explicitly checks for "container" in cidr_networks, which limits the use of arbitrary cidrs for custom environments.

https://github.com/openstack/openstack-ansible/blob/master/playbooks/inventory/dynamic_inventory.py#L932-L937

The check should be removed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/277511

[Miguel Alejandro Cantu (miguel-cantu)]

It doesn't seem to be an issue anymore. It looks like the code checks the substring of the variable name now: https://github.com/openstack/openstack-ansible/blob/master/playbooks/inventory/dynamic_inventory.py#L1226-L1232.

[Jean-Philippe Evrard (jean-philippe-evrard)]

This is not relevant anymore:

https://github.com/openstack/openstack-ansible/blob/a1bc7d1902620b317c0f5d1b1f2d927f001086d0/playbooks/inventory/dynamic_inventory.py#L1227-L1233

As you can see there, the naming requirement is not as strong as it was before, and corresponds to what Alex was looking for.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (odyssey4me) (<email address hidden>) on branch: master
Review: https://review.openstack.org/277511
Reason: Abandoning due to lack of feedback or revision.