only install one of nova_console_novnc or nova_console to haproxy

[Alex]

On liberty, nova_console_type: defaults to spice, and so only spice service is installed. However, both spice and novnc services are installed in haproxy, resulting in:

Jan 28 07:12:51 localhost haproxy[19832]: Server nova_console_novnc-back/control1_nova_console_container-70a248f8 is DOWN, reason: Layer4 connection problem, info: "Connection refused", check duration: 0ms. 1 active and 0 backup servers left. 0 sessions active, 0 requeued, 0 remaining in queue.
Jan 28 07:12:51 localhost haproxy[19832]: Server nova_console_novnc-back/control2_nova_console_container-eac512fa is DOWN, reason: Layer4 connection problem, info: "Connection refused", check duration: 1ms. 0 active and 0 backup servers left. 0 sessions active, 0 requeued, 0 remaining in queue.
Jan 28 07:12:51 localhost haproxy[19832]: backend nova_console_novnc-back has no server available!

in the logs.

Fix seems to be in playbooks/vars/configs/haproxy_config.yml to only add the appropriate service based on nova_console_type setting, but not sure how best to do that in ansible.

[Jesse Pretorius (jesse-pretorius)]

This is simply a cosmetic error, so it's not essential to resolve.

There are two approaches:

https://github.com/openstack/openstack-ansible/blob/master/playbooks/vars/configs/haproxy_config.yml#L122-L139 will need to reference a different group for each console type so that it's more aware. Each console type would need to be in a container group that specifies the type. This is a fairly major architecture change.

The alternative is to revamp the as has been WIP in https://github.com/evrardjp/ansible-haproxy - this is our preferred solution.

[Jean-Philippe Evrard (jean-philippe-evrard)]

Another commit would bring the modularity too:
https://review.openstack.org/#/c/301343/

I'll follow this.

[Jean-Philippe Evrard (jean-philippe-evrard)]

FYI, the revamp using https://github.com/evrardjp/ansible-haproxy will wait for the inclusion ansible 2. in openstack-ansible, to make use of combine filters and facts delegation (it will also bring multi os support).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/336680

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/336680
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=b5117918365d6b2a06439fcf42e2fe500bebd0bb
Submitter: Jenkins
Branch: master

commit b5117918365d6b2a06439fcf42e2fe500bebd0bb
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jul 1 18:18:09 2016 +0100

    HAProxy: configure either novnc or spice

    Instead of having one useless backend, this conditionally deploys what's
    needed. This consumes the override set by the deployer.

    Closes-Bug: 1539246

    Change-Id: I532a9bbb443a564534d7f083674fa3d39398a8bc
    Signed-off-by: Jean-Philippe Evrard <email address hidden>

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 14.0.0.0b2 development milestone.