haproxy config fails when containers are missing

Bug #1513455 reported by Kevin Carter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Kevin Carter
Kilo
Fix Released
Medium
Tom Cameron
Liberty
Fix Released
Medium
Jesse Pretorius
Trunk
Fix Released
Medium
Kevin Carter

Bug Description

The basic haproxy configuration file found here [ https://github.com/openstack/openstack-ansible/blob/master/playbooks/vars/configs/haproxy_config.yml ] needs to to have the backend entries with a default value of a list. This is needed when using the haproxy role in a n environment that is not an All in one and is using pieces of a OSA and a partial inventory as set in the user configuration files. To fix this eacho of the backend names should have a list entry as the default.

Changed in openstack-ansible:
importance: Undecided → Medium
assignee: nobody → Kevin Carter (kevin-carter)
status: New → Confirmed
milestone: none → 12.0.1
Changed in openstack-ansible:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/242033
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=589650228bb2678487b5750688fe403095955db7
Submitter: Jenkins
Branch: master

commit 589650228bb2678487b5750688fe403095955db7
Author: Kevin Carter <email address hidden>
Date: Thu Nov 5 06:48:41 2015 -0600

    Fixed haproxy backend config issue

    The change updates the haproxy configs to use backends with a
    default of an empty array. This is needed to ensure that the backends
    are not being assumed to have some value. In the current system if an
    inventory item did not exist the rendered backend would be a jinja
    string which would cause the haproxy play to fail.

    Closes-Bug: #1513455

    Change-Id: I221dbd910c75c2e41c98a33e1c38c7f69718b544
    Signed-off-by: Kevin Carter <email address hidden>

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (liberty)

Fix proposed to branch: liberty
Review: https://review.openstack.org/245883

summary: - haproxy config needs a default list
+ haproxy config fails when containers are missing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (liberty)

Reviewed: https://review.openstack.org/245883
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=d9dd18f9664c911c4fc936ac4ca5372b0f40364c
Submitter: Jenkins
Branch: liberty

commit d9dd18f9664c911c4fc936ac4ca5372b0f40364c
Author: Kevin Carter <email address hidden>
Date: Thu Nov 5 06:48:41 2015 -0600

    Fixed haproxy backend config issue

    The change updates the haproxy configs to use backends with a
    default of an empty array. This is needed to ensure that the backends
    are not being assumed to have some value. In the current system if an
    inventory item did not exist the rendered backend would be a jinja
    string which would cause the haproxy play to fail.

    Closes-Bug: #1513455

    Change-Id: I221dbd910c75c2e41c98a33e1c38c7f69718b544
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 589650228bb2678487b5750688fe403095955db7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/253180

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (kilo)

Reviewed: https://review.openstack.org/253180
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=19d00527dd2cfbd1db1360e183a5dab7a2fab0b1
Submitter: Jenkins
Branch: kilo

commit 19d00527dd2cfbd1db1360e183a5dab7a2fab0b1
Author: Kevin Carter <email address hidden>
Date: Thu Nov 5 06:48:41 2015 -0600

    Fixed haproxy backend config issue

    The change updates the haproxy configs to use backends with a
    default of an empty array. This is needed to ensure that the backends
    are not being assumed to have some value. In the current system if an
    inventory item did not exist the rendered backend would be a jinja
    string which would cause the haproxy play to fail.

    Closes-Bug: #1513455

    Change-Id: I221dbd910c75c2e41c98a33e1c38c7f69718b544
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 589650228bb2678487b5750688fe403095955db7)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.11

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 12.0.8

This issue was fixed in the openstack/openstack-ansible 12.0.8 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 11.2.12

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 12.0.9

This issue was fixed in the openstack/openstack-ansible 12.0.9 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 13.0.0

This issue was fixed in the openstack/openstack-ansible 13.0.0 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

This issue was fixed in the openstack/openstack-ansible 13.0.0 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 12.0.11

This issue was fixed in the openstack/openstack-ansible 12.0.11 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 11.2.15

This issue was fixed in the openstack/openstack-ansible 11.2.15 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.