lvm.conf template overwrites local configs

[Serge van Ginderachter]

The openstack_hosts role owns an lvm.conf template that is deployed on the metal hosts. The same happens in the os_cinder role, but that one deploys within the container. and we only encountered this problem on the metal hosts, who had a preconfigured, non standard lvm.conf.

In our case, lvm.conf was updated with an additional type, enabling to use a Ceph block device as an LVM Physical Volume:

devices {
..
types = [ "rbd", 1024 ]
..
}

(We use Ceph to back a separate mountpoint on /openstack)

Deploying the openstack_hosts role overwrites lvm.conf, lost this change, which broke the whole installation on the metal host, only to be noticed after an occasional reboot.

While this is a very specific configuration, perhaps also other lvm.conf configuration changes might apply.

Some additional options or parameters should be allowed to tackle these kind of use cases.

In it's most minimal case, we need to be able to add this additional device types, hence needing an additional parameter handled by the lvm.conf template.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/227277

[OpenStack Infra (hudson-openstack)]

Change abandoned by git-harry (<email address hidden>) on branch: master
Review: https://review.openstack.org/227277
Reason: Only solves half the problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228447

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: master
Review: https://review.openstack.org/228447
Reason: This has been untouched for close to three months, so it's being abandoned. If you intend to work on it, then please restore it.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306436
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=bb1db353230191f4ba2b5148846427ad6f715485
Submitter: Jenkins
Branch: master

commit bb1db353230191f4ba2b5148846427ad6f715485
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Apr 15 14:44:33 2016 +0100

    Doc: Improved documentation about LVM overwrite behaviour

    LVM configuration is overwritten on nodes part of the hosts group.
    This documentation explains that behaviour to a deployer, because
    he may not think at first sight that its LVM configuration could
    be overwritten in hosts others than the cinder ones.

    Change-Id: I82769250f057bac28385cf63c8e1df7c7df511f5
    Closes-Bug: #1488532

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/307681

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/307681
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=9b849f4777b95bb2d806965a16152399658e5ea5
Submitter: Jenkins
Branch: stable/mitaka

commit 9b849f4777b95bb2d806965a16152399658e5ea5
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Apr 15 14:44:33 2016 +0100

    Doc: Improved documentation about LVM overwrite behaviour

    LVM configuration is overwritten on nodes part of the hosts group.
    This documentation explains that behaviour to a deployer, because
    he may not think at first sight that its LVM configuration could
    be overwritten in hosts others than the cinder ones.

    Change-Id: I82769250f057bac28385cf63c8e1df7c7df511f5
    Closes-Bug: #1488532
    (cherry picked from commit bb1db353230191f4ba2b5148846427ad6f715485)

[Jesse Pretorius (jesse-pretorius)]

Marking Kilo as won't fix as it's a stable branch with security fixes only.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 13.0.1 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 13.0.1 release.

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/openstack-ansible 14.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 14.0.0.0b2 development milestone.