autodev for cinder-volumes in containers now fails

Bug #1483650 reported by Andy McCrae on 2015-08-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-ansible
High
Andy McCrae
Kilo
High
Matt Thompson
Trunk
High
Andy McCrae

Bug Description

If we run cinder-volumes in a container it will now fail to setup correctly because of changes made in https://review.openstack.org/#/c/202268/ to set autodev to 1 on all containers.

We should set this to 0 on cinder_volumes containers when running in containers.

Fix proposed to branch: master
Review: https://review.openstack.org/211502

Changed in openstack-ansible:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/211502
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=e85592d54cacd521efb30ac373693bb1e9425c1b
Submitter: Jenkins
Branch: master

commit e85592d54cacd521efb30ac373693bb1e9425c1b
Author: Andy McCrae <email address hidden>
Date: Tue Aug 11 11:58:49 2015 +0100

    Set lxc.autodev=0 for cinder_volumes in containers

    With cinder_volumes we were creating a specific udev device, this will
    fail to mount if lxc.autodev=1. This should only be required when lvm is
    a backend for the cinder_volumes container.

    We can specify lxc.autodev=0 for cinder_volumes containers. To do this
    properly we first check if lvm is in use. We can also use this to ensure
    that redundant "lvm" configuration isn't setup on volumes hosts with no
    lvm backend.

    Additionally this will fix the formatting on the "udev" lxc.mount.entry
    as it was adding additional spaces.

    Change-Id: Iabe72003ebcfefe11d360131fdde64ca4b21a192
    Closes-Bug: #1483650

Changed in openstack-ansible:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/215634
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=eecf311e3fe2e45be89d29cf3fbc5f75210638ae
Submitter: Jenkins
Branch: kilo

commit eecf311e3fe2e45be89d29cf3fbc5f75210638ae
Author: Andy McCrae <email address hidden>
Date: Tue Aug 11 11:58:49 2015 +0100

    Set lxc.autodev=0 for cinder_volumes in containers

    With cinder_volumes we were creating a specific udev device, this will
    fail to mount if lxc.autodev=1. This should only be required when lvm is
    a backend for the cinder_volumes container.

    We can specify lxc.autodev=0 for cinder_volumes containers. To do this
    properly we first check if lvm is in use. We can also use this to ensure
    that redundant "lvm" configuration isn't setup on volumes hosts with no
    lvm backend.

    Additionally this will fix the formatting on the "udev" lxc.mount.entry
    as it was adding additional spaces.

    Change-Id: Iabe72003ebcfefe11d360131fdde64ca4b21a192
    Closes-Bug: #1483650
    (cherry picked from commit e85592d54cacd521efb30ac373693bb1e9425c1b)

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers