When apt sources are changed, the old config is left behind causing conflicts

[Bjoern]

A upgrade from 10.1.10 to kilo (branch) did fail with the error during a apt-get update :

0 upgraded, 0 newly installed, 0 to remove and 3 not upgraded.W: Duplicate sources.list entry http://mirror.rackspace.com/mariadb/repo/5.5/ubuntu/ trusty/main amd64 Packages (/var/lib/apt/lists/mirror.rackspace.com_mariadb_repo_5.5_ubuntu_dists_trusty_main_binary-amd64_Packages)
W: Duplicate sources.list entry http://mirror.rackspace.com/mariadb/repo/5.5/ubuntu/ trusty/main i386 Packages (/var/lib/apt/lists/mirror.rackspace.com_mariadb_repo_5.5_ubuntu_dists_trusty_main_binary-i386_Packages)
W: You may want to run apt-get update to correct these problems

The issues seems to be inside the mirror_rackspace_com_mariadb_repo_5_5_ubuntu.list after we added the https mirror URL

deb https://mirror.rackspace.com/mariadb/repo/5.5/ubuntu trusty main
deb http://mirror.rackspace.com/mariadb/repo/5.5/ubuntu trusty main

inside the apt_repository task.
At this point we should unregister the old repo (http)

[Nolan Brubaker (nolan-brubaker)]

I can confirm I'm seeing this on a 10.1.10 to kilo head (SHA 221daab63f6a1d2032eddb132cf25846f3d893ec) upgrade. However, my install finished successfully.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: kilo
Review: https://review.openstack.org/201691

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/201696

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: kilo
Review: https://review.openstack.org/201691
Reason: Abandoning the kilo review until the master review https://review.openstack.org/201696 is merged.

[Jesse Pretorius (jesse-pretorius)]

As there doesn't appear to be any consensus on the approach and the patch hasn't been actively worked on for some time, the milestone target has been shifted to 11.1.1. Please discuss this at either of the two community meetings (Tue/Thu) if this is not a suitable milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: master
Review: https://review.openstack.org/201696
Reason: No activity for over a month. Please restore this patch if/when it will be worked on again.

[Jesse Pretorius (jesse-pretorius)]

Removing the assignee and changing the status to new to discuss this at the next bug triage meeting.

[Jesse Pretorius (jesse-pretorius)]

Setting trunk to invalid as this is not applicable to the Kilo->Liberty upgrade.

[Bjoern (bjoern-t)]

FYI, during the latest upgrade test I did not see this issues again, because we are simply not adding the SSL repo in the repo file anymore.

[Jesse Pretorius (jesse-pretorius)]

Marking as invalid as per BJoern's feedback.

[Bjoern (bjoern-t)]

It seems we still encounter this issue reported at 1506975

[Jesse Pretorius (jesse-pretorius)]

Setting trunk to invalid as this is not applicable to the Kilo->Liberty upgrade.

[Bjoern (bjoern-t)]

So it seems this issue make more sense to fix once https://github.com/ansible/ansible-modules-core/pull/2696 has been merged.
That fix will add the option to specify a fixed filename for a repo configuration.
Other then that we can only proceed with https://review.openstack.org/#/c/201696/ which would remove old files before putting a new config in place.

[Major Hayden (rackerhacker)]

It looks like the ansible module PR merged -- can this bug move forward now, Bjoern?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: kilo
Review: https://review.openstack.org/289977

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/289977
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=235c2b29be7fa4777a455377f401066e557c9f21
Submitter: Jenkins
Branch: kilo

commit 235c2b29be7fa4777a455377f401066e557c9f21
Author: Major Hayden <email address hidden>
Date: Tue Mar 22 08:03:09 2016 -0500

    Remove old MariaDB apt sources

    In Juno, MariaDB's apt sources used plaintext HTTP. This causes
    problems for Kilo upgrades since the new apt sources use HTTPS urls.
    This patch adds an upgrade playbook that removes any sources left
    over from Juno that use HTTP.

    Closes-Bug: 1473525

    Change-Id: Ia10d9dc1eff624bca785805a910ee7835a559463

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

[David Wilde (dave-wilde)]

This will need to be forwarded into Liberty as environments that upgraded to older versions of Kilo and then on to Liberty will hit this issue.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309170
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=613473db20fec87501f157811905a116639dc4f9
Submitter: Jenkins
Branch: liberty

commit 613473db20fec87501f157811905a116639dc4f9
Author: Major Hayden <email address hidden>
Date: Thu Apr 21 15:17:09 2016 -0500

    Remove old MariaDB repos during upgrades

    This upgrade playbook removes older MariaDB apt repositories
    which used HTTP URLs.

    Closes-bug: 1473525

    Change-Id: Id02c4aca108bb35182a622865e8a00d9b7182f5a

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 11.2.15 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 12.0.12 release.