Ansible modules not being lint tested

Bug #1473002 reported by Jesse Pretorius
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Jesse Pretorius
Icehouse
Won't Fix
Medium
Jesse Pretorius
Juno
Won't Fix
Medium
Jesse Pretorius
Kilo
Fix Released
Medium
Jesse Pretorius
Trunk
Fix Released
Medium
Jesse Pretorius

Bug Description

The gate-check-lint file includes a flake8 test on all files that include the line matching the regex '^#!/usr/bin/env python' or '^#!/bin/python', but python is actually installed in '/usr/bin/python' which is what's being used in the Ansible modules we're carrying.

The lint check should be adjusted to pick up this line in the file and any flake8 failures need to be fixed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/200006

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/200006
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=f827d8d0159afd475a6b717d5e618d30b102ace1
Submitter: Jenkins
Branch: master

commit f827d8d0159afd475a6b717d5e618d30b102ace1
Author: Jesse Pretorius <email address hidden>
Date: Thu Jul 9 11:38:51 2015 +0100

    Ensure that flake8 runs against all python files

    This patch ensures that all python files (including the
    Ansible modules) are included in the flake8 test.

    This patch also fixes the current flake8 failures found in the
    Ansible modules we're carrying.

    Change-Id: I9ebef6ef7bbd2e424ad1be26d593471fd6fd3056
    Closes-Bug: #1473002

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/200122

Revision history for this message
Jesse Pretorius (jesse-pretorius) wrote :

There are currently no python lint checks in Icehouse/Juno, so this issue does not apply.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (kilo)

Reviewed: https://review.openstack.org/200122
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=ca4967de826fec8b386f8ff9e1a5cc76c454a75d
Submitter: Jenkins
Branch: kilo

commit ca4967de826fec8b386f8ff9e1a5cc76c454a75d
Author: Jesse Pretorius <email address hidden>
Date: Thu Jul 9 11:38:51 2015 +0100

    Ensure that flake8 runs against all python files

    This patch ensures that all python files (including the
    Ansible modules) are included in the flake8 test.

    This patch also fixes the current flake8 failures found in the
    Ansible modules we're carrying.

    Change-Id: I9ebef6ef7bbd2e424ad1be26d593471fd6fd3056
    Closes-Bug: #1473002
    (cherry picked from commit f827d8d0159afd475a6b717d5e618d30b102ace1)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.11

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 11.2.12

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.