repo links create multiple entries

[Kevin Carter]

The pip config links.d directory contains link files that represent URLs that will be used to locate pip packages. In the Master/Kilo releases the `openstack_release.link` file is used to denote links to online repos however the task [ https://github.com/stackforge/os-ansible-deployment/blob/master/playbooks/roles/pip_lock_down/tasks/main.yml#L55-L62 ] uses the ansible line in file method which allows for multiple links to be created in the same file. This creates a situation where upon upgrade the user may have multiple link entries within the same file which slows down deployment and is unnecessary. The task in the pip-lock-down roles should be replaced with a template such that it contains one link entry per file.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: kilo
Review: https://review.openstack.org/195397

[Ian Cordasco (icordasc)]

https://review.openstack.org/#/q/I4fef53baf075c953ac73500e72f9388f7ccfa2a0,n,z has both changes for the curious

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/195397
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=e8a4d7bd3f364eeb8f89b0aa74cc8442eece1288
Submitter: Jenkins
Branch: kilo

commit e8a4d7bd3f364eeb8f89b0aa74cc8442eece1288
Author: kevin <email address hidden>
Date: Wed Jun 24 22:04:53 2015 -0500

    Changed link lineinfile to template

    This change ensures that all link files created are built from a template
    rather than using the lineinfile module which will result in multiple entries
    per file. While these multiple entries do not break deployments they do create
    a slower install / upgrade time.

    Change-Id: I4fef53baf075c953ac73500e72f9388f7ccfa2a0
    Closes-Bug: #1468587
    (cherry picked from commit a4179512bc8e3680a5c6e1fb702af18eb62ee841)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.