SYMLINK_DIR used in scripts/bootstrap_aio.sh but not defined

Bug #1434315 reported by Nolan Brubaker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Nolan Brubaker
Juno
Fix Released
Medium
Nolan Brubaker
Trunk
Fix Released
Medium
Nolan Brubaker

Bug Description

Inside of scripts/bootstrap_aio.sh, the $SYMLINK_DIR variable is referenced to create the openstack logs symlink, but this variable is actually defined/exported in scripts/gate-check-commit.sh.

I would propose either moving the symlink operation into gate-check-commit.sh or define the variable in scripts/bootstrap_aio.sh as well

While the AIO process is, in general, most used by the gate, it is sometimes useful to quickly set up a machine for development and testing.

Changed in openstack-ansible:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/167316
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=ec2113f05c61fb47ab3e9e1dc5a2bbf35eb72bb2
Submitter: Jenkins
Branch: master

commit ec2113f05c61fb47ab3e9e1dc5a2bbf35eb72bb2
Author: Nolan Brubaker <email address hidden>
Date: Tue Mar 24 12:40:32 2015 -0400

    Move SYMLINK_DIR declaration to bootstrap-aio.sh

    The gate-check-commit.sh script defined the SYMLINK_DIR variable, but it
    was only used in bootstrap-aio.sh. This meant that using
    bootstrap-aio.sh by itself would fail due to the undefined variable.

    This change moves the declaration to boostrap-aio.sh so that an AIO can
    be boostrapped without necessitating a gate check.

    Change-Id: Id1b20379c5837cdd4b3df03de42f0ea612e3fbb5
    Closes-Bug: #1434315

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (juno)

Fix proposed to branch: juno
Review: https://review.openstack.org/170303

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (juno)

Reviewed: https://review.openstack.org/170303
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=ce26c77301355104830546b1237b802676b4bc56
Submitter: Jenkins
Branch: juno

commit ce26c77301355104830546b1237b802676b4bc56
Author: Nolan Brubaker <email address hidden>
Date: Tue Mar 24 12:40:32 2015 -0400

    Move SYMLINK_DIR declaration to bootstrap-aio.sh

    The gate-check-commit.sh script defined the SYMLINK_DIR variable, but it
    was only used in bootstrap-aio.sh. This meant that using
    bootstrap-aio.sh by itself would fail due to the undefined variable.

    This change moves the declaration to boostrap-aio.sh so that an AIO can
    be boostrapped without necessitating a gate check.

    Closes-Bug: #1434315
    (cherry picked from commit ec2113f05c61fb47ab3e9e1dc5a2bbf35eb72bb2)

    Conflicts:
     scripts/bootstrap-aio.sh
     scripts/gate-check-commit.sh

    Change-Id: Id1b20379c5837cdd4b3df03de42f0ea612e3fbb5

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.