get-pip.py will not get the latest version of get-pip.py and won't overwrite existing get-pip.py

Bug #1429165 reported by Andy McCrae
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Andy McCrae

Bug Description

If get-pip.py fails for some reason but gets a blank file re-runs will never work because the get_url module won't get the file if destination already exists in any form (regardless of whether its different or not).

This is also the case where a newer version of get-pip.py is added, the old version won't be overwritten.

Changed in openstack-ansible:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/162183

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/162183
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=1bfbe3be25b40df403c2bf332ef60a0c6a0f2884
Submitter: Jenkins
Branch: master

commit 1bfbe3be25b40df403c2bf332ef60a0c6a0f2884
Author: Andy McCrae <email address hidden>
Date: Fri Mar 6 15:08:34 2015 +0000

    Ensure get-pip.py is retrieved properly

    Without force: "yes" the get_url module will only retrieve the file if
    the destination doesn't exist. This causes issues if, for example, the
    get-pip.py exists but is empty (due to an issue), or if the get-pip.py
    is updated at some point.

    Change-Id: I9d6933c837e0e38d51dfb57a3eddd1ca461e0723
    Closes-Bug: #1429165

Changed in openstack-ansible:
status: In Progress → Fix Committed
Changed in openstack-ansible:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.