Remove Rackspace-Specific Playbooks From the openstack-ansible Repo

Bug #1403676 reported by Sean Carlisle on 2014-12-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-ansible
Medium
Jesse Pretorius

Bug Description

The Rackspace-specific playbooks and roles (such as those containing the name rpc_support) should not be part of the openstack-ansible repository because they are specific to Rackspace processes and procedures (e.g. the installation of Holland and the Rackspace-specific motd, to name a couple of examples.) I'm creating this bug report to start a conversation around moving this code to another location.

Nolan Brubaker (nolan-brubaker) wrote :

Thanks for filing the bug - we also have a blueprint up to begin working on this very thing: https://blueprints.launchpad.net/openstack-ansible/+spec/rackspace-namesake

Changed in openstack-ansible:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Kevin Carter (kevin-carter)
Changed in openstack-ansible:
milestone: none → next
tags: added: juno-backport-potential

Reviewed: https://review.openstack.org/155342
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=81c4ab04f70239f76f7c1ff9ab8fb9cb68f7843e
Submitter: Jenkins
Branch: master

commit 81c4ab04f70239f76f7c1ff9ab8fb9cb68f7843e
Author: Jesse Pretorius <email address hidden>
Date: Wed Feb 11 16:26:22 2015 +0000

    Remove and/or rename Rackspace related bits

    This patch removes and/or renames anything that is Rackspace specific
    from the playbooks, roles and variables.

    It also removes items which appear to be orphaned/unused and flattens
    the playbooks into a single directory in order to better match ansible
    best practise (and remove some horrible fiddles we were doing).

    The following have been removed due to RAX/RPC naming or RAX/RPC
    specific usage:
     - playbooks/monitoring
     - playbooks/rax*
     - playbooks/rpc*
     - roles/maas*
     - roles/rax*
     - roles/rpc*
     - scripts/f5-*
     - scripts/maas*
     - scripts/rpc*
     - scripts/*lab*
     - vars/repo_packages/rackspace*
     - vars/repo_packages/rax*
     - vars/repo_packages/rpc*
     - vars/repo_packages/holland.yml

    The following have been removed as they are unused:
     - playbooks/setup/host-network-setup.yml
     - roles/openssl_pem_request
     - roles/host_interfaces
     - scripts/elsa*
     - ssh/
     - vars/repo_packages/turbolift.yml

    The following directories have been renamed:
     - etc/rpc_deploy > etc/openstack_deploy
     - rpc_deployment > playbooks

    The playbooks have all been moved into a single directory:
     - rpc_deployment/playbooks/infrastructure/* > playbooks/
     - rpc_deployment/playbooks/openstack/* > playbooks/
     - rpc_deployment/playbooks/setup/* > playbooks/

    The following files have been renamed:
     - lxc-rpc > lxc-openstack
     - lxc-rpc.conf > lxc-openstack.conf
     - rpc_environment > openstack_environment
     - rpc_release > openstack_release (etc and pip)
     - rpc_tempest_gate.sh > openstack_tempest_gate.sh
     - rpc_user_config > openstack_user_config

    The following variables have been renamed:
     - rpc_release > openstack_release
     - rpc_repo_url > openstack_repo_url

    The following variables have been introduced:
     - openstack_code_name: The code name of the upstream OpenStack release
       (eg: Juno)

    Notable variable/template value changes:
     - rabbit_cluster_name: rpc > openstack
     - wsrep_cluster_name: rpc_galera_cluster > openstack_galera_cluster

    DocImpact
    Closes-Bug: #1403676
    Implements: blueprint rackspace-namesake
    Change-Id: Ib480fdad500b03c7cb90684aa444da9946ba8032

Changed in openstack-ansible:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/152753
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=8e6dbd01c9924ebecffdc04f74e4f6d042610ed8
Submitter: Jenkins
Branch: master

commit 8e6dbd01c9924ebecffdc04f74e4f6d042610ed8
Author: Kevin Carter <email address hidden>
Date: Sat Feb 14 10:06:50 2015 -0600

    Convert existing roles into galaxy roles

    This change implements the blueprint to convert all roles and plays into
    a more generic setup, following upstream ansible best practices.

    Items Changed:
    * All tasks have tags.
    * All roles use namespaced variables.
    * All redundant tasks within a given play and role have been removed.
    * All of the repetitive plays have been removed in-favor of a more
      simplistic approach. This change duplicates code within the roles but
      ensures that the roles only ever run within their own scope.
    * All roles have been built using an ansible galaxy syntax.
    * The `*requirement.txt` files have been reformatted follow upstream
      Openstack practices.
    * Dynamically generated inventory is now more organized, this should assist
      anyone who may want or need to dive into the JSON blob that is created.
      In the inventory a properties field is used for items that customize containers
      within the inventory.
    * The environment map has been modified to support additional host groups to
      enable the seperation of infrastructure pieces. While the old infra_hosts group
      will still work this change allows for groups to be divided up into seperate
      chunks; eg: deployment of a swift only stack.
    * The LXC logic now exists within the plays.
    * etc/openstack_deploy/user_variables.yml has all password/token
      variables extracted into the separate file
      etc/openstack_deploy/user_secrets.yml in order to allow seperate
      security settings on that file.

    Items Excised:
    * All of the roles have had the LXC logic removed from within them which
      should allow roles to be consumed outside of the `os-ansible-deployment`
      reference architecture.

    Note:
    * the directory rpc_deployment still exists and is presently pointed at plays
      containing a deprecation warning instructing the user to move to the standard
      playbooks directory.
    * While all of the rackspace specific components and variables have been removed
      and or were refactored the repository still relies on an upstream mirror of
      Openstack built python files and container images. This upstream mirror is hosted
      at rackspace at "http://rpc-repo.rackspace.com" though this is
      not locked to and or tied to rackspace specific installations. This repository
      contains all of the needed code to create and/or clone your own mirror.

    DocImpact
    Co-Authored-By: Jesse Pretorius <email address hidden>
    Closes-Bug: #1403676
    Implements: blueprint galaxy-roles
    Change-Id: I03df3328b7655f0cc9e43ba83b02623d038d214e

Changed in openstack-ansible:
assignee: Kevin Carter (kevin-carter) → Jesse Pretorius (jesse-pretorius)
Changed in openstack-ansible:
status: Fix Committed → Fix Released
Changed in openstack-ansible:
milestone: next → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers