[XMPP] C drones do not directly terminate Jabber streams upon self-exit

Bug #2047701 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSRF
New
Low
Unassigned

Bug Description

C service drones do not explicitly terminate their XMPP sessions by sending a "</stream:stream>" message prior to exiting voluntarily (as opposed to being terminated by the listener). Instead, the socket just gets closed when the process ends. (Perl services do cleanly end their XMPP session upon self-exit.)

This doesn't appear to be the end of the world, but it does cause "Connection failed: connection closed" noise in the Ejabberd logs that can mask true connection failures.

Looks like osrf_prefork_child_exit() is where the client connection cleanup would be added.

Tags: pullrequest
Galen Charlton (gmc)
Changed in opensrf:
importance: Undecided → Low
Revision history for this message
Galen Charlton (gmc) wrote :

Patch is available in the branch user/gmcharlt/lp2047701_graceful_xmpp_disconnect_c / https://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2047701_graceful_xmpp_disconnect_c

tags: added: pullrequest
description: updated
summary: - [XMPP] C drones do not directly terminate Jabber streams upon exit
+ [XMPP] C drones do not directly terminate Jabber streams upon self-exit
Galen Charlton (gmc)
description: updated
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.