OpenSRF

Websockets JS fails to handle handle transport errors

Bug #1776510 reported by Bill Erickson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenSRF
Fix Released
Medium
Unassigned
OpenSRF 3.0.2
2.5
Fix Committed
Medium
Unassigned
OpenSRF 2.5.3
3.1
Fix Released
Medium
Unassigned
OpenSRF 3.1-beta

Bug Description

OpenSRF 3.0.1

Requests made to the Websocket gateway for unavailable services result in a bounced message including a transport_error=1 attribute on the websocket message wrapper. This flag is currently ignored by the OpenSRF JS libs, so no error handlers are called. Instead, the request typically silently fails causing any pending promises to hang / callbacks not to get fired.

First noted in the fix for bug #1755258.

Patch en route.

Tags: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Fix pushed:

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/berick/lp1776510-js-transport-errors

Changed in opensrf:
assignee: Bill Erickson (berick) → nobody
milestone: none → 3.0.2
Bill Erickson (berick)
tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_0, and rel_2_5. Thanks, Bill!

Changed in opensrf:
status: New → Fix Committed
status: Fix Committed → Confirmed
importance: Undecided → Medium
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in opensrf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.