Revert unnecessary encode for byte counting
Bug #1717526 reported by
Dan Wells
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenSRF |
New
|
Low
|
Unassigned |
Bug Description
A recent commit added an encode step to Perl response chunking to account for multi-byte characters, but...
"It's not necessary. we don't actually put 2+ byte chars in json strings
we publish. we always \u-escape them. so bytes == chars for json we
publish. So, it's not only unnecessary, but it's confusing for future
us'es."
--Mike Rylander
Revert plus new comment here:
working/
Changed in opensrf: | |
importance: | Undecided → Low |
To post a comment you must log in.
Thanks, Dan. Here's a branch that signs off on your commit and adds another with inline documentation and a minor optimization.
http:// git.evergreen- ils.org/ ?p=working/ OpenSRF. git;a=shortlog; h=refs/ heads/collab/ miker/revert_ perl_encode_ byte_counting