Revert unnecessary encode for byte counting

Bug #1717526 reported by Dan Wells on 2017-09-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSRF
Low
Unassigned

Bug Description

A recent commit added an encode step to Perl response chunking to account for multi-byte characters, but...

"It's not necessary. we don't actually put 2+ byte chars in json strings
we publish. we always \u-escape them. so bytes == chars for json we
publish. So, it's not only unnecessary, but it's confusing for future
us'es."
--Mike Rylander

Revert plus new comment here:

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/collab/dbwells/revert_perl_encode_byte_counting

working/collab/dbwells/revert_perl_encode_byte_counting

Mike Rylander (mrylander) wrote :

Thanks, Dan. Here's a branch that signs off on your commit and adds another with inline documentation and a minor optimization.

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/collab/miker/revert_perl_encode_byte_counting

Galen Charlton (gmc) on 2018-05-07
Changed in opensrf:
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers