don't require mod_perl as an OpenSRF dependency

Bug #1579219 reported by Galen Charlton on 2016-05-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned
OpenSRF
Wishlist
Unassigned

Bug Description

As a historical accident of the process of splitting OpenSRF out from the Evergreen code base, mod_perl is installed during the OpenSRF installation process, not Evergreen's.

This is a bit untidy as OpenSRF proper includes no mod_perl handlers. It does include one check of the MOD_PERL environment variable, but that doesn't require that mod_perl itself be installed.

Consequently, mod_perl should be listed as an *Evergreen* dependency, not an OpenSRF one.

Galen Charlton (gmc) on 2016-05-06
Changed in evergreen:
importance: Undecided → Wishlist
milestone: none → 2.next
Galen Charlton (gmc) on 2016-08-12
Changed in opensrf:
milestone: none → 2.5-alpha
Changed in evergreen:
milestone: 2.next → 2.11-beta
Galen Charlton (gmc) wrote :

A patch implementing the Evergreen side of it is available at the tip of the user/gmcharlt/lp1579219_move_mod_perl_dep_to_eg branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1579219_move_mod_perl_dep_to_eg

Galen Charlton (gmc) wrote :

And the OpenSRF side is available in the user/gmcharlt/lp1579219_move_mod_perl_dep_from_osrf branch:

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1579219_move_mod_perl_dep_from_osrf

tags: added: pullrequest
Ben Shum (bshum) wrote :

Tested successfully on Debian Jessie and Ubuntu Trusty. With moving the installation of mod_perl over to the Evergreen side of things, we also bypass the issue uncovered with bug 1585042. Will favor this fix over the ones proposed over there.

I didn't sign off or push anything, but basically this is ready to go in whenever gmcharlt is ready to finish juggling pieces for OpenSRF 2.5-alpha.

In case I don't get to push it myself... I have tested this code and consent to signing off on it with my name, Ben Shum and my email address, <email address hidden>.

Changed in evergreen:
status: New → Triaged
Changed in opensrf:
status: New → Triaged
Ben Shum (bshum) wrote :

Bringing this one back to the forefront as needed now that we're making OpenSRF 2.5.0 a reality. Need to push both the OpenSRF side to remove mod-perl dependency and also add to Evergreen side the pieces needed.

Retargeting Evergreen side to 2.12-rc for inclusion.

Changed in evergreen:
milestone: 2.11-beta → 2.12-rc
Ben Shum (bshum) wrote :

Based on conversation with Galen on original patch idea, going ahead and making mod_perl a core dependency that's installed on Evergreen side of things, and also making sure to enable perl via the apache mods list.

Pushed to Evergreen master for 2.12.

Holding off on the removal of mod_perl from OpenSRF side for now. We can always choose to remove it in a future release series of OpenSRF. Even if we end up checking to install it in both Evergreen and OpenSRF, we're very safe in making sure that mod_perl is installed and activated either way.

Changed in evergreen:
status: Triaged → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers