srfsh file.srfsh display output for only the first request

Bug #1461625 reported by Galen Charlton
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenSRF
Fix Released
Low
Unassigned

Bug Description

Running "srfsh script.srfsh" or script.srfsh as a shebang script will process all of the commands in a multi-line script... but will print output only for the first request. In contrast, "srfsh < script.srfsh" displays the output of every request.

The expected behavior is that the output of every request be displayed.

OpenSRF master

Tags: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available at the tip of the user/gmcharlt/lp1461625_srfsh_multiline_script_output branch in the working/OpenSRF repository:

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1461625_srfsh_multiline_script_output

tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

Test plan:

    [1] Create a srfsh script containing:

        request opensrf.math opensrf.system.echo "foo"
        request opensrf.math opensrf.system.echo "bar"

    [2] Run "srfsh script.srfsh". Note that only the
        results of the first echo request are output.
    [3] Apply the patch and recompile, then run
        "srfsh script.srfsh" again. This time, the
        output of both requests is displayed.

Revision history for this message
Mike Rylander (mrylander) wrote :

WORKSFORME

Picked to master and 2.4 with signoff. Thanks, Galen!

Changed in opensrf:
status: New → Fix Committed
Galen Charlton (gmc)
Changed in opensrf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.