OpenSRF

Per-tab websocket JS connections can re-send messages

Bug #1418613 reported by Bill Erickson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenSRF
Fix Released
Medium
Unassigned
OpenSRF 2.4.1

Bug Description

OpenSRF 2.4

Thinko in the code where the wrong variable is referenced within OpenSRF.Session.prototype.send_ws(), resulting in some cases in message re-sends. Happens in particular when the client uses CONNECT/DISCONNECT. Instead of sending the final DISCONNECT, the previously sent message is re-sent. Patch en route.

Tags: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/berick/lp1418613-websocket-per-tab-thinko

Changed in opensrf:
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Changed in opensrf:
milestone: none → 2.4.0
Ben Shum (bshum)
Changed in opensrf:
milestone: 2.4.0 → 2.4.1
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Mike Rylander (mrylander) wrote :

Picked into master and rel_2_4. Thanks!

Changed in opensrf:
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in opensrf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.