compilation warnings on Ubuntu 12.04.3 LTS
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenSRF |
Fix Released
|
Low
|
Unassigned |
Bug Description
A user encountered the following compilation warnings building OpenSRF 2.2.1 on Ubuntu 12.04.3 LTS:
...
.deps/libosrf_
utils.c: In function 'set_proc_title':
utils.c:133:2: warning: format not a string literal and no format arguments [-Wformat-security]
utils.c:133:2: warning: format not a string literal and no format arguments [-Wformat-security]
utils.c: In function 'stringisnum':
utils.c:697:8: warning: ignoring return value of 'strtol', declared with attribute warn_unused_result [-Wunused-result]
utils.c: In function 'daemonize':
utils.c:665:8: warning: ignoring return value of 'chdir', declared with attribute warn_unused_result [-Wunused-result]
utils.c:672:10: warning: ignoring return value of 'freopen', declared with attribute warn_unused_result [-Wunused-result]
utils.c:673:10: warning: ignoring return value of 'freopen', declared with attribute warn_unused_result [-Wunused-result]
utils.c:674:10: warning: ignoring return value of 'freopen', declared with attribute warn_unused_result [-Wunused-result]
...
.deps/osrf_
osrf_legacy_json.c: In function ‘json_eat_comment’:
osrf_legacy_
osrf_legacy_json.c: In function ‘jsonObjectIter
osrf_legacy_
osrf_legacy_
mv -f .deps/osrf_
…
srfsh.c: In function ‘process_request’:
srfsh.c:367:9: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result [-Wunused-result]
….
/osrf_http_
./osrf_
/usr/include/
These are likely benign, but it would be best if the build were clean.
OpenSRF: 2.2.1 (and probably also master)
Changed in opensrf: | |
milestone: | none → 2.5.3 |
Changed in opensrf: | |
status: | Fix Committed → Fix Released |
I've begun a collab branch here:
http:// git.evergreen- ils.org/ ?p=working/ OpenSRF. git;a=shortlog; h=refs/ heads/collab/ csharp/ lp1243841_ fix_compilation _warnings
I would appreciate more experienced eyes on this, of course :-).