Prevent srfsh commands run from scripts going into history
Bug #1152272 reported by
Pasi Kallinen
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenSRF |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
srfsh scripts run from eg. cronjob put the commands in the user's .srfsh_history. Commands run via scripts should not do that.
Setting HISTSIZE=0 in crontab has no effect.
Changed in opensrf: | |
status: | New → Confirmed |
Changed in opensrf: | |
importance: | Undecided → Wishlist |
milestone: | none → 2.4.1 |
Changed in opensrf: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
A patch is available at the tip of the user/gmcharlt/ lp1152272_ keep_batch_ srfsh_out_ of_history branch in the working/OpenSRF repository:
http:// git.evergreen- ils.org/ ?p=working/ OpenSRF. git;a=shortlog; h=refs/ heads/user/ gmcharlt/ lp1152272_ keep_batch_ srfsh_out_ of_history
Test plan:
[1] Run the following command:
echo 'request opensrf.math opensrf.system.echo "foo"' | srfsh
[2] Note that the last line of ~/.srfsh_history should be
'request opensrf.math opensrf.system.echo "foo"'
[3] Apply the patch, compile, and run
echo 'request opensrf.math opensrf.system.echo "bar"' | srfsh
[4] This time, no additional line should have been added to
~/.srfsh_ history
[5] Another variation to try:
srfsh test.srfsh