The Replace Clip command doesn't replace the proper in/out length properties for the new clip

Bug #841378 reported by Mr Surbade
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Medium
Unassigned

Bug Description

The length is the same but not the in/out points

Related branches

Revision history for this message
Andy Finch (fincha) wrote :

It was done like that as in most cases the replacement clip will be a different length, but we can probably enhance it to check if the length is the same, and then it that case use the existing start/end points.

Changed in openshot:
status: New → Confirmed
Revision history for this message
Berg (emil-berg91) wrote :

This patch fixes that. If the file length is the same for both the file of the clip that is getting replaced and the new file, it uses the same in and out points.
It also fixes two other minor issues:
1) If a folder was right clicked, a separator was shown at the bottom of the menu.
2) If something that wasn't a video clip was right clicked on the timeline, double separators were shown in the menu.

Revision history for this message
Olivier Girard (eolinwen) wrote :

Thanks a lot Emil not only for this one but for all your work.

Changed in openshot:
importance: Undecided → Low
milestone: none → 1.4.0
Revision history for this message
Mr Surbade (surbade) wrote :

Yes, thanks for your work Emil. The world need more people like you.

Revision history for this message
Andy Finch (fincha) wrote :

Thanks, this has been applied to the trunk. I also noticed the thumbnail wasn't getting updated on the replacement clip, so I fixed that too.

Changed in openshot:
status: Confirmed → Fix Committed
Changed in openshot:
importance: Low → Medium
Andy Finch (fincha)
Changed in openshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.