Problems with speed and reverse

Bug #676133 reported by None
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
New
Undecided
Unassigned

Bug Description

## Problem with speed :

  Length of a video part does not update when I want to play it slower.

  I needed to comment some part of the code to make it working :

  openshot-1.2.2/windows/ClipProperties.py : 808
    ##if speed_multiplier < original_speed:
      # clip is longer now (keep the short version)
      ##clip_object.end_time = clip_object.start_time + original_length
    ##else:
      # clip is shorter
    clip_object.end_time = new_end_time

## Problem with reverse :

  When I want to play a part of a video in reverse, it does not keep the good part of the video
  I changed a part of the code :

  openshot-1.2.2/windows/ClipProperties.py : 813
    if localcboDirection.lower() == _("Reverse").lower():
      clip_object.reversed = True
      tmp = clip_object.start_time
      clip_object.start_time = clip_object.max_length - clip_object.end_time
      clip_object.end_time = clip_object.max_length - tmp
    else:
      clip_object.reversed = False

But I'm not too good in coding... it works but only at normal speed. when I want to make it slower, I have an other part of the video again

Tags: mlt reverse
Revision history for this message
Olivier Girard (eolinwen) wrote :

Don't worry for that. And thanks a lot. It is a begin. It will be check and will include in the next version after.

Changed in openshot:
milestone: none → 1.3.0
Revision history for this message
None (b-launchpad-veugeois-fr) wrote :

I think I found why the patch wasn't working with reverse at low speed, I changed it (file openshot-diff).

But I'm not able to see the video neither. I guess the player does not manage reverse video at low speed.

I tried with a cutted clip of 15 seconds, output timestamps seem good but I get a white windows when I try to play the video :

on_mnuClipProperties_activate
on_txtOut_value_changed
on_cboKeyFrame_changed
on_txtHeight_value_changed
on_txtWidth_value_changed
on_scaleAlpha_value_changed
on_cboSimpleSpeed_changed
===original_speed : 1.000000
===localtxtIn : 0.000000
===localtxtOut : 14.925000
===localtxtLength : 14.925000
===localreverse : 0.000000
---clip_object.speed : 1.000000
---clip_object.max_length : 331.998333
---clip_object.start_time : 0.000000
---clip_object.end_time : 14.925000
===clip_object.reversed : 0.000000
===clip_object.start_time : 0.000000
===clip_object.end_time : 14.925000
on_frmClipProperties_configure_event
on_frmClipProperties_configure_event
on_frmClipProperties_configure_event
on_frmClipProperties_configure_event
on_frmClipProperties_configure_event
on_frmClipProperties_configure_event
on_cboSimpleSpeed_changed
on_frmClipProperties_configure_event
on_frmClipProperties_configure_event
on_btnClose_clicked
===original_speed : 1.000000
===localtxtIn : 0.000000
===localtxtOut : 14.925000
===localtxtLength : 14.925000
===localreverse : 0.000000
---clip_object.speed : 0.500000
---clip_object.max_length : 663.996667
---clip_object.start_time : 634.146667
---clip_object.end_time : 663.996667
===clip_object.reversed : 1.000000
===clip_object.start_time : 634.146667
===clip_object.end_time : 663.996667
project modified: Modified clip properties
state saved
first_image == NULL get image died
first_image == NULL get image died
first_image == NULL get image died
first_image == NULL get image died
first_image == NULL get image died
first_image == NULL get image died
first_image == NULL get image died
first_image == NULL get image died
first_image == NULL get image died

Revision history for this message
Olivier Girard (eolinwen) wrote :

In fact, yes.
You can used it. Do a test like this.
In a video clip, appy a slow speed (in the tab speed). You look the application of the effect in the preview. In the middle, stop it. After, clic on the previous button (the 3 in the left) and see the result.

Revision history for this message
None (b-launchpad-veugeois-fr) wrote : Re: [Bug 676133] Re: Problems with speed and reverse

Hi !

  I tried you test, but if I change Speed to 1/2 and Direction to
Reverse on a split video, I can have any image on the preview neither,
It stays white.

Thanks for your help.

Best regards.

None

On 24/11/2010 16:35, cenwen wrote:
> In fact, yes.
> You can used it. Do a test like this.
> In a video clip, appy a slow speed (in the tab speed). You look the application of the effect in the preview. In the middle, stop it. After, clic on the previous button (the 3 in the left) and see the result.
>
> -- Problems with speed and reverse
> https://bugs.launchpad.net/bugs/676133 You received this bug
> notification because you are a direct subscriber of the bug. Status in
> OpenShot Video Editor: New Bug description: ## Problem with speed :
> Length of a video part does not update when I want to play it slower.
> I needed to comment some part of the code to make it working :
> openshot-1.2.2/windows/ClipProperties.py : 808 ##if speed_multiplier <
> original_speed: # clip is longer now (keep the short version)
> ##clip_object.end_time = clip_object.start_time + original_length
> ##else: # clip is shorter clip_object.end_time = new_end_time ##
> Problem with reverse : When I want to play a part of a video in
> reverse, it does not keep the good part of the video I changed a part
> of the code : openshot-1.2.2/windows/ClipProperties.py : 813 if
> localcboDirection.lower() == _("Reverse").lower():
> clip_object.reversed = True tmp = clip_object.start_time
> clip_object.start_time = clip_object.max_length - clip_object.end_time
> clip_object.end_time = clip_object.max_length - tmp else:
> clip_object.reversed = False But I'm not too good in coding... it
> works but only at normal speed. when I want to make it slower, I have
> an other part of the video again To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/openshot/+bug/676133/+subscribe

Revision history for this message
Olivier Girard (eolinwen) wrote :

Ah i have done an error. Sorry. I have not test with the reverse function but just only with the preview without this one.
It was a bug of MLT and i was believing that was resolved. I am using the version 0.5.10 and you ?
sudo apt-cache policy melt

Revision history for this message
None (b-launchpad-veugeois-fr) wrote :

I had the 0.5.6

The same issue with 0.5.10

$ aptitude show melt
Package: melt
State: installed
Automatically installed: yes

None

On 25/11/2010 18:09, cenwen wrote:
> Ah i have done an error. Sorry. I have not test with the reverse function but just only with the preview without this one.
> It was a bug of MLT and i was believing that was resolved. I am using the version 0.5.10 and you ?
> sudo apt-cache policy melt
>
> -- Problems with speed and reverse
> https://bugs.launchpad.net/bugs/676133 You received this bug
> notification because you are a direct subscriber of the bug. Status in
> OpenShot Video Editor: New Bug description: ## Problem with speed :
> Length of a video part does not update when I want to play it slower.
> I needed to comment some part of the code to make it working :
> openshot-1.2.2/windows/ClipProperties.py : 808 ##if speed_multiplier <
> original_speed: # clip is longer now (keep the short version)
> ##clip_object.end_time = clip_object.start_time + original_length
> ##else: # clip is shorter clip_object.end_time = new_end_time ##
> Problem with reverse : When I want to play a part of a video in
> reverse, it does not keep the good part of the video I changed a part
> of the code : openshot-1.2.2/windows/ClipProperties.py : 813 if
> localcboDirection.lower() == _("Reverse").lower():
> clip_object.reversed = True tmp = clip_object.start_time
> clip_object.start_time = clip_object.max_length - clip_object.end_time
> clip_object.end_time = clip_object.max_length - tmp else:
> clip_object.reversed = False But I'm not too good in coding... it
> works but only at normal speed. when I want to make it slower, I have
> an other part of the video again To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/openshot/+bug/676133/+subscribe

tags: added: mlt reverse
Revision history for this message
Dstl (dstilio) wrote :

that is actually the same problem we are facing here:
https://bugs.launchpad.net/openshot/+bug/667806

Nice to see that there is a step forward this issue :)

Revision history for this message
Seppo Erviälä (seppo-erviala) wrote :

This bug is still present in 1.3.1

Revision history for this message
None (b-launchpad-veugeois-fr) wrote :

You can use the second fix, posted on comment #2 (openshot-diffs)
Lines are not exactly the same, but you should update ClipProperties.py in order to fix the bug.
The only thing which won't be fixed, it's if you want to reverse a clip AND change the speed

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.