Crash when previewing OSP files from an older version of OpenShot

Reported by Daniel Ellis on 2010-08-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Medium
Unassigned

Bug Description

My old OSP project files no longer work. The application segfaults when previewing at the point it reaches certain transitions.

I have identified that the OSP files include references to paths such as '/usr/share/openshot/transitions/sand.svg' which no longer exists. I think the paths have since changed to something like '/usr/share/pyshared/openshot/transitions'.

Could we make it so OpenShot scans these paths when the project is opened to make sure they exist? Maybe it could then show a dialogue for resolving missing files. I think the same dialogue would be useful for finding other missing resources, for example, in the scenario where someone has moved the folder which contains their source video.

The dialogue could offer options such as fully automatic scanning for the files, or offer the ability to point to a base path to scan.

Related branches

Olivier Girard (eolinwen) wrote :

Hi,
I think that 's normal, you have saved your .osp file in the format ascii and not in binary like it is in the preferences. In the next version (i.e. 1.2.0) it will be changed automatically in the binary format.
So for this reasons i 'am not sure that what you preconise is possible but i'll tag in the whitelist. Thanks for the suggestion and the interest for OpenShot.

Changed in openshot:
importance: Undecided → Wishlist
Daniel Ellis (danellisuk) wrote :

I can see that OpenShot already contains a loop to check for missing files when a project is opened. However, it only currently checks for missing project files (which are displayed in the Project Files list).

I've attached a patch which also checks the transitions in the project file, and it displays a similar warning message.

It doesn't automatically change any paths, but at least it can provide a hint to the user before the application segfaults.

Andy Finch (fincha) wrote :

Thanks for the patch!

Changed in openshot:
status: New → Confirmed
milestone: none → 1.2.0
Jonathan Thomas (jonoomph) wrote :

Thanks for the patch Daniel! I have committed the patch to the trunk. I also made a few changes. OpenShot now updates any missing transition to a "dissolve", so it won't seg fault. So to recap, the user gets a nice message on what is missing, and OpenShot will still work without seg faulting.

Changed in openshot:
importance: Wishlist → Medium
status: Confirmed → Fix Committed
Daniel Ellis (danellisuk) wrote :

Yes, defaulting to the dissolve transition works nicely. But I have just seen a small problem with my first patch. If I open one of my larger projects, the list of missing transitions is very long, and so this second patch now only displays a unique list of missing files, and it also sorts the list. This patch was from made from the latest revision (298).

Andy Finch (fincha) on 2010-09-23
Changed in openshot:
status: Fix Committed → Fix Released
John Volk (poweruser32) on 2011-06-14
tags: added: patch
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers