default button not defined for clip properties dialog

[Christian Weiske]

In the clip properties dialog, the "return" key does not apply the settings and close the window.

How to reproduce:
1. Add an image/video to the project, drop it onto the timeline, right-click it and open "Properties".
2. Modify a setting, e.g. the Length/Out value
3. Press return
4. Nothing happens

I expect the dialog to be closed as if I clicked the "Apply" button with the mouse.

---
Architecture (64 bits or 32 bits) : 64bit
Operating System & version: Ubuntu 13.10
Installation Method : Default packages
Version of Openshot installed : 1.4.3-1

[Olivier Girard (eolinwen)]

Hi Christian,

What do you have in the output of the terminal when you run OS/it in this
one ?

2014/1/3 Christian Weiske <email address hidden>

> Public bug reported:
>
> In the clip properties dialog, the "return" key does not apply the
> settings and close the window.
>
> How to reproduce:
> 1. Add an image/video to the project, drop it onto the timeline,
> right-click it and open "Properties".
> 2. Modify a setting, e.g. the Length/Out value
> 3. Press return
> 4. Nothing happens
>
> I expect the dialog to be closed as if I clicked the "Apply" button with
> the mouse.
>
> ---
> Architecture (64 bits or 32 bits) : 64bit
> Operating System & version: Ubuntu 13.10
> Installation Method : Default packages
> Version of Openshot installed : 1.4.3-1
>
> ** Affects: openshot
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are a member of OpenShot
> Bugs, which is subscribed to OpenShot Video Editor.
> https://bugs.launchpad.net/bugs/1265888
>
> Title:
> default button not defined for clip properties dialog
>
> Status in OpenShot Video Editor:
> New
>
> Bug description:
> In the clip properties dialog, the "return" key does not apply the
> settings and close the window.
>
> How to reproduce:
> 1. Add an image/video to the project, drop it onto the timeline,
> right-click it and open "Properties".
> 2. Modify a setting, e.g. the Length/Out value
> 3. Press return
> 4. Nothing happens
>
> I expect the dialog to be closed as if I clicked the "Apply" button
> with the mouse.
>
> ---
> Architecture (64 bits or 32 bits) : 64bit
> Operating System & version: Ubuntu 13.10
> Installation Method : Default packages
> Version of Openshot installed : 1.4.3-1
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openshot/+bug/1265888/+subscriptions
>
> --
> Mailing list: https://launchpad.net/~openshot.bugs
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.bugs
> More help : https://help.launchpad.net/ListHelp
>

--
Olivier
Cenwen un elfe sur la banquise/ an elve on the ice
Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot :
http://linuxevolution.wordpress.com/
Le forum d'Openshot où vous me trouverez : http://openshotusers.com/
http://openshotusers.com/forum/index.php
Nothing is lost until the last second.
The family motto : When we want, we can.
Astuces, Actualités, Logiciels, bref sur tout ce que je ne fais d'articles
dessus Google+ <https://plus.google.com/u/0/111472725110173916234/posts>

[Christian Weiske (cweiske)]

on_mnuClipProperties_activate
on_txtOut_value_changed
on_cboKeyFrame_changed
on_cboSimpleSpeed_changed
Warning: effect not found in your version of Frei0r: frei0r.alphagrad
Warning: effect not found in your version of Frei0r: frei0r.coloradj_RGB
Warning: effect not found in your version of Frei0r: frei0r.defish0r
Warning: effect not found in your version of Frei0r: frei0r.sharpness
Warning: effect not found in your version of Frei0r: frei0r.vignette
on_treeEffects_button_release_event
on_frmClipProperties_configure_event
on_frmClipProperties_configure_event
on_txtOut_value_changed

[Olivier Girard (eolinwen)]

Strange, at first look, you seem to have an old version of freior-plugins.
What is the version of theses ?

2014/1/3 Christian Weiske <email address hidden>

> on_mnuClipProperties_activate
> on_txtOut_value_changed
> on_cboKeyFrame_changed
> on_cboSimpleSpeed_changed
> Warning: effect not found in your version of Frei0r: frei0r.alphagrad
> Warning: effect not found in your version of Frei0r: frei0r.coloradj_RGB
> Warning: effect not found in your version of Frei0r: frei0r.defish0r
> Warning: effect not found in your version of Frei0r: frei0r.sharpness
> Warning: effect not found in your version of Frei0r: frei0r.vignette
> on_treeEffects_button_release_event
> on_frmClipProperties_configure_event
> on_frmClipProperties_configure_event
> on_txtOut_value_changed
>
> --
> You received this bug notification because you are a member of OpenShot
> Bugs, which is subscribed to OpenShot Video Editor.
> https://bugs.launchpad.net/bugs/1265888
>
> Title:
> default button not defined for clip properties dialog
>
> Status in OpenShot Video Editor:
> New
>
> Bug description:
> In the clip properties dialog, the "return" key does not apply the
> settings and close the window.
>
> How to reproduce:
> 1. Add an image/video to the project, drop it onto the timeline,
> right-click it and open "Properties".
> 2. Modify a setting, e.g. the Length/Out value
> 3. Press return
> 4. Nothing happens
>
> I expect the dialog to be closed as if I clicked the "Apply" button
> with the mouse.
>
> ---
> Architecture (64 bits or 32 bits) : 64bit
> Operating System & version: Ubuntu 13.10
> Installation Method : Default packages
> Version of Openshot installed : 1.4.3-1
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openshot/+bug/1265888/+subscriptions
>
> --
> Mailing list: https://launchpad.net/~openshot.bugs
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.bugs
> More help : https://help.launchpad.net/ListHelp
>

--
Olivier
Cenwen un elfe sur la banquise/ an elve on the ice
Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot :
http://linuxevolution.wordpress.com/
Le forum d'Openshot où vous me trouverez : http://openshotusers.com/
http://openshotusers.com/forum/index.php
Nothing is lost until the last second.
The family motto : When we want, we can.
Astuces, Actualités, Logiciels, bref sur tout ce que je ne fais d'articles
dessus Google+ <https://plus.google.com/u/0/111472725110173916234/posts>

[Christian Weiske (cweiske)]

I did not install any plugins. I simply installed openshot from the ubuntu packages and nothing else. There does not seem to be any "plugin" or "freior" files in the openshot package.

[Olivier Girard (eolinwen)]

Directly, exactly. But normally, they are installed in the same time.
FreOr-plugins give you effects in Openshot.
Unfortunately, I can't test because i don't have Ubuntu 13.10 installed,
just the 13.04.

2014/1/5 Christian Weiske <email address hidden>

> I did not install any plugins. I simply installed openshot from the
> ubuntu packages and nothing else. There does not seem to be any "plugin"
> or "freior" files in the openshot package.
>
> --
> You received this bug notification because you are a member of OpenShot
> Bugs, which is subscribed to OpenShot Video Editor.
> https://bugs.launchpad.net/bugs/1265888
>
> Title:
> default button not defined for clip properties dialog
>
> Status in OpenShot Video Editor:
> New
>
> Bug description:
> In the clip properties dialog, the "return" key does not apply the
> settings and close the window.
>
> How to reproduce:
> 1. Add an image/video to the project, drop it onto the timeline,
> right-click it and open "Properties".
> 2. Modify a setting, e.g. the Length/Out value
> 3. Press return
> 4. Nothing happens
>
> I expect the dialog to be closed as if I clicked the "Apply" button
> with the mouse.
>
> ---
> Architecture (64 bits or 32 bits) : 64bit
> Operating System & version: Ubuntu 13.10
> Installation Method : Default packages
> Version of Openshot installed : 1.4.3-1
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openshot/+bug/1265888/+subscriptions
>
> --
> Mailing list: https://launchpad.net/~openshot.bugs
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.bugs
> More help : https://help.launchpad.net/ListHelp
>

--
Olivier
Cenwen un elfe sur la banquise/ an elve on the ice
Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot :
http://linuxevolution.wordpress.com/
Le forum d'Openshot où vous me trouverez : http://openshotusers.com/
http://openshotusers.com/forum/index.php
Nothing is lost until the last second.
The family motto : When we want, we can.
Astuces, Actualités, Logiciels, bref sur tout ce que je ne fais d'articles
dessus Google+ <https://plus.google.com/u/0/111472725110173916234/posts>

[Olivier Girard (eolinwen)]

Check if they are installed and if the version available is egal to 1.3.0
(at least).
If not, follow this FAQ : https://answers.launchpad.net/openshot/+faq/2101
Its could help you.

2014/1/14 <email address hidden> <email address hidden>

> Directly, exactly. But normally, they are installed in the same time.
> FreOr-plugins give you effects in Openshot.
> Unfortunately, I can't test because i don't have Ubuntu 13.10 installed,
> just the 13.04.
>
>
>
> 2014/1/5 Christian Weiske <email address hidden>
>
>> I did not install any plugins. I simply installed openshot from the
>> ubuntu packages and nothing else. There does not seem to be any "plugin"
>> or "freior" files in the openshot package.
>>
>> --
>> You received this bug notification because you are a member of OpenShot
>> Bugs, which is subscribed to OpenShot Video Editor.
>> https://bugs.launchpad.net/bugs/1265888
>>
>> Title:
>> default button not defined for clip properties dialog
>>
>> Status in OpenShot Video Editor:
>> New
>>
>> Bug description:
>> In the clip properties dialog, the "return" key does not apply the
>> settings and close the window.
>>
>> How to reproduce:
>> 1. Add an image/video to the project, drop it onto the timeline,
>> right-click it and open "Properties".
>> 2. Modify a setting, e.g. the Length/Out value
>> 3. Press return
>> 4. Nothing happens
>>
>> I expect the dialog to be closed as if I clicked the "Apply" button
>> with the mouse.
>>
>> ---
>> Architecture (64 bits or 32 bits) : 64bit
>> Operating System & version: Ubuntu 13.10
>> Installation Method : Default packages
>> Version of Openshot installed : 1.4.3-1
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/openshot/+bug/1265888/+subscriptions
>>
>> --
>> Mailing list: https://launchpad.net/~openshot.bugs
>> Post to : <email address hidden>
>> Unsubscribe : https://launchpad.net/~openshot.bugs
>> More help : https://help.launchpad.net/ListHelp
>>
>
>
>
> --
> Olivier
> Cenwen un elfe sur la banquise/ an elve on the ice
> Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot :
> http://linuxevolution.wordpress.com/
> Le forum d'Openshot où vous me trouverez : http://openshotusers.com/
> http://openshotusers.com/forum/index.php
> Nothing is lost until the last second.
> The family motto : When we want, we can.
> Astuces, Actualités, Logiciels, bref sur tout ce que je ne fais d'articles
> dessus Google+ <https://plus.google.com/u/0/111472725110173916234/posts>
>

--
Olivier
Cenwen un elfe sur la banquise/ an elve on the ice
Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot :
http://linuxevolution.wordpress.com/
Le forum d'Openshot où vous me trouverez : http://openshotusers.com/
http://openshotusers.com/forum/index.php
Nothing is lost until the last second.
The family motto : When we want, we can.
Astuces, Actualités, Logiciels, bref sur tout ce que je ne fais d'articles
dessus Google+ <https://plus.google.com/u/0/111472725110173916234/posts>

[Christian Weiske (cweiske)]

Ok, I updated the frei0r plugins package from https://launchpad.net/~sunab/+archive/kdenlive-release to version 1.4.0+git...

With the new version of the totally unrelated plugins, I still have the same issue about the return key not working in the clip properties window.

The output is now:

on_frmClipProperties_configure_event
on_frmClipProperties_configure_event
on_txtIn_value_changed
on_txtIn_value_changed

That's all.

[Olivier Girard (eolinwen)]

okay. I've better learn all again and make again some tests. You have
reason, the key enter doesn't give us the result expected i.e apply like
when we make this operation with the apply button.

2014/1/18 Christian Weiske <email address hidden>

> Ok, I updated the frei0r plugins package from
> https://launchpad.net/~sunab/+archive/kdenlive-release to version
> 1.4.0+git...
>
> With the new version of the totally unrelated plugins, I still have the
> same issue about the return key not working in the clip properties
> window.
>
> The output is now:
>
> on_frmClipProperties_configure_event
> on_frmClipProperties_configure_event
> on_txtIn_value_changed
> on_txtIn_value_changed
>
> That's all.
>
> --
> You received this bug notification because you are a member of OpenShot
> Bugs, which is subscribed to OpenShot Video Editor.
> https://bugs.launchpad.net/bugs/1265888
>
> Title:
> default button not defined for clip properties dialog
>
> Status in OpenShot Video Editor:
> New
>
> Bug description:
> In the clip properties dialog, the "return" key does not apply the
> settings and close the window.
>
> How to reproduce:
> 1. Add an image/video to the project, drop it onto the timeline,
> right-click it and open "Properties".
> 2. Modify a setting, e.g. the Length/Out value
> 3. Press return
> 4. Nothing happens
>
> I expect the dialog to be closed as if I clicked the "Apply" button
> with the mouse.
>
> ---
> Architecture (64 bits or 32 bits) : 64bit
> Operating System & version: Ubuntu 13.10
> Installation Method : Default packages
> Version of Openshot installed : 1.4.3-1
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openshot/+bug/1265888/+subscriptions
>
> --
> Mailing list: https://launchpad.net/~openshot.bugs
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.bugs
> More help : https://help.launchpad.net/ListHelp
>

--
Olivier
Cenwen un elfe sur la banquise/ an elve on the ice
Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot :
http://linuxevolution.wordpress.com/
Le forum d'Openshot où vous me trouverez : http://openshotusers.com/
http://openshotusers.com/forum/index.php
Nothing is lost until the last second.
The family motto : When we want, we can.
Astuces, Actualités, Logiciels, bref sur tout ce que je ne fais d'articles
dessus Google+ <https://plus.google.com/u/0/111472725110173916234/posts>

[Richard Poole (9-rp)]

The attached patch fixes this bug and also similar issues with several other interface windows, including removing some unnecessary widget properties. Only the XML files are affected, so I hope it can be applied without needing a lot of review.

[Andy Finch (fincha)]

Thanks for the patch.

It's highly unlikely there will be another Openshot release based on this codeline. Development is focussed on Openshot 2.0 which uses the QT toolkit.

So while your patch is very handy for anyone that wants to apply it themselves to the current version, we won't be able to use it for Openshot 2.0.