Removing Meets from a MeetCollection in the MeetCollection GUI removes the Meet from storage

[Ken McLean]

Removing Meets from a MeetCollection in the MeetCollection GUI removes the Meet from storage, not the association between the Meet and the MeetCollection.

This deletes the entire meet. Oops!

[Ken McLean (kenmclean)]

A few errors associated with this:

java.lang.NullPointerException
        at avscoreswt.gui.Meets.MeetsTree$5.widgetSelected(MeetsTree.java:222)
        at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422)
        at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
        at org.eclipse.jface.window.Window.open(Window.java:801)
        at avscoreswt.gui.BaseFrame.run(BaseFrame.java:191)
        at avscoreswt.gui.BaseFrame.start(BaseFrame.java:1103)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at avscoreswt.OpenScore.main(OpenScore.java:62)

AND

15:03:17.609:INFO :Added Meet[5] object to MODIFIED queue.
15:03:18.984:INFO :Added Meet[5] object to DELETE queue.
15:03:20.125:INFO :Added Meet[8] object to DELETE queue.
java.lang.ClassCastException: java.util.ArrayList cannot be cast to avscoreswt.core.interfaces.IMeetCollection
        at avscoreswt.gui.Meets.MeetsTree$MyContentProvider.getParent(MeetsTree.java:294)
        at org.eclipse.jface.viewers.AbstractTreeViewer.getParentElement(AbstractTreeViewer.java:1653)
        at org.eclipse.jface.viewers.TreeViewer.getParentElement(TreeViewer.java:606)
        at org.eclipse.jface.viewers.AbstractTreeViewer.internalExpand(AbstractTreeViewer.java:1580)
        at org.eclipse.jface.viewers.AbstractTreeViewer.internalExpand(AbstractTreeViewer.java:1582)
        at org.eclipse.jface.viewers.AbstractTreeViewer.setSelectionToWidget(AbstractTreeViewer.java:2470)
        at org.eclipse.jface.viewers.AbstractTreeViewer.setSelectionToWidget(AbstractTreeViewer.java:2900)
        at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1399)
        at org.eclipse.jface.viewers.TreeViewer.preservingSelection(TreeViewer.java:402)
        at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1353)
        at org.eclipse.jface.viewers.StructuredViewer.refresh(StructuredViewer.java:1455)
        at org.eclipse.jface.viewers.ColumnViewer.refresh(ColumnViewer.java:537)
        at org.eclipse.jface.viewers.StructuredViewer.refresh(StructuredViewer.java:1414)
        at avscoreswt.gui.Meets.MeetsTree$5.widgetSelected(MeetsTree.java:201)
        at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422)
        at org.eclipse.jface.window.Window.runEventLoop(Window.ja...

[Craig Mahony (cmahony)]

Think I have one ok now but please test.

[Ken McLean (kenmclean)]

Right, I wasn't doing things right.

I think the REMOVE icon next to the list of meets should not be there. Clicking remove removes the entire meet, without warning. It should just be a list of meets on the right table.

I want to change the way this GUI works one day. But for now it'll do.