Importing an invalid Groups Template data file throws NPE

Bug #412831 reported by Ken McLean
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenScore
Fix Committed
Low
Craig Mahony

Bug Description

Importing an invalid group data file throws NPE

1. Go to Pre-meet > Groups Template
2. Hit Import Groups
3. Select an invalid csv file
Nullpointer is thrown, and no warning or error is given to the user.

Debug:

13:46:39.343:INFO :It took 15 milliseconds to import the group data.
java.lang.NullPointerException
        at avscoreswt.gui.Groups.GroupsTemplateGui$10.mouseUp(GroupsTemplateGui.java:406)
        at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:207)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422)
        at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
        at org.eclipse.jface.window.Window.open(Window.java:801)
        at avscoreswt.gui.BaseFrame.run(BaseFrame.java:191)
        at avscoreswt.gui.BaseFrame.start(BaseFrame.java:1102)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at avscoreswt.OpenScore.main(OpenScore.java:62)

Revision history for this message
Craig Mahony (cmahony) wrote :

Should be fixed now.

Changed in openscore:
status: New → Fix Committed
Revision history for this message
Ken McLean (kenmclean) wrote :
Download full text (5.6 KiB)

Negative.

17:30:09.265:INFO :Added Group object to NEW queue.
17:30:09.265:Last message repeated 2 times.
17:30:09.265:ERROR:java.lang.ArrayIndexOutOfBoundsException: 1
17:30:09.265:INFO :It took 15 milliseconds to import the group data.
java.lang.NullPointerException
        at avscoreswt.gui.Groups.GroupsTemplateGui$11.mouseUp(GroupsTemplateGui.
java:403)
        at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:
207)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422)
        at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
        at org.eclipse.jface.window.Window.open(Window.java:801)
        at avscoreswt.gui.BaseFrame.run(BaseFrame.java:194)
        at avscoreswt.gui.BaseFrame.start(BaseFrame.java:1114)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at avscoreswt.OpenScore.main(OpenScore.java:61)
17:30:32.812:INFO :Poll files for changes.
17:30:32.828:INFO :Files polled and (potentially) data updated.
17:30:32.828:INFO :Flushing wait queue
17:30:32.828:Last message repeated 2 times.
17:30:32.828:INFO :CSVFile:AppendLines x 2:Groups.csv
17:30:32.859:INFO :CSVFile:1 Locks Open
17:30:32.859:INFO :Changed
17:30:32.859:INFO :CSVFile:Reading matrix for Groups.csv
17:30:32.859:INFO :CSVFile:Continuing with existing write lock on Groups.csv
17:30:32.859:INFO :CSVFile:Opened file for reading Groups.csv
17:30:32.859:INFO :CSVFile:Loaded contents of Groups.csv into memory. 1069 bytes
.
17:30:32.859:INFO :CSVFile:Matrix read from Groups.csv. Max line number is 47.
17:30:32.859:INFO :CSVFile:Matrix is 48 lines.
17:30:32.859:INFO :CSVFile:AppendLines[48]:Groups.csv:,##0.00\)?? " "$"#,##0.00
_);[Red]\("$"#,##0.00\)??7 * 2 _("$"* #,##0_);_("$"* \(#,##0\);_("$"* "-"_);_(@
_)??. ) ) _(* #,##0_);_(* \(#,##0\);_(* "-"_);_(@_)??? , : _("$"* #,##0.00_);_
("$"* \(#,##0.00\);_("$"* "-"??_);_(@_)??6 + 1 _(* #,##0.00_);_(* \(#,##0.00\);
_(* "-"??_);_(@_)??? ñ 0.00000??? Ñ ? 0.0000??
 ª ? 0.000? º ? 0.0a ¶ )  + a ¶ ? )  ( + a ¶ ? )
  ( + a ¶ ? )  ( + a ¶ ? )  ( + a ¶ )  (
   + a ¶ )  ( + a ¶ )  ( + a ¶ )  ( + a ¶
     )  ( + a ¶ )  ( + a ¶ )  ( + a ¶ )
  ( + a ¶ )  ( + a ¶ )  ( + a ¶ ?
   + a ¶ ? + )  ° + a ¶ ? ) )  ° + a ¶ ? , )  ° + a ¶
 ? * )  ° + a ¶ ? )  ° + a ¶ ? ? + a ¶ ? ?
   H ? a ¶ ? @ ? a ¶ ? ? D ?/ a ¶ ? @
 ?) a ¶ ? ? D ?* a ¶ ? ? ? + ô?? ?Ç? ô?? ?Ç? ô?? ?Ç? ô??
?Ç ô?? Ç...

Read more...

Changed in openscore:
status: Fix Committed → In Progress
Revision history for this message
Craig Mahony (cmahony) wrote :

Another fix for this bug has been committed.

Changed in openscore:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.