No ladders output for washout round (No team entries)

Bug #314268 reported by Tudor Holton
2
Affects Status Importance Assigned to Milestone
OpenScore
Fix Committed
High
Craig Mahony

Bug Description

When calculating Ladders for a round without team entries, no ladders are output.

The ladders output should be identical to the previous round.

Ken McLean (kenmclean)
Changed in openscore:
assignee: nobody → tudor
Revision history for this message
Craig Mahony (cmahony) wrote :

This seems to have been fixed at some stage as if I open a meet with no results and get the ladder it works.

Changed in openscore:
status: New → Fix Committed
Revision history for this message
Ken McLean (kenmclean) wrote :

Not quite.

When you change all events to PB for a meet, ladder is output identical to previous meet (as desired).

When you delete all the Team Entries, instead of outputting the ladder, it triggers a warning "an error occurred while exporting Ladders" and stops the process.

Is this the desired functionality? If so, could the warning please say "No Team Entries exist. Cannot calculate ladders."

Changed in openscore:
status: Fix Committed → Triaged
Ken McLean (kenmclean)
Changed in openscore:
milestone: none → heatwave
Ken McLean (kenmclean)
Changed in openscore:
importance: Undecided → High
Revision history for this message
Craig Mahony (cmahony) wrote :

If there are no team entries for a round it now goes and looks up the last meet that had team entries and uses those.

Changed in openscore:
assignee: Tudor Holton (tudor) → Craig Mahony (cmahony)
status: Triaged → Fix Committed
Revision history for this message
Ken McLean (kenmclean) wrote :

Is that actually the best thing to do? Wouldn't it be better to prompt the user with:

"Cannot calculate ladders. No Team Entries exist for this Meet. Would you like to use the Team Entries from Meet 'x' instead?"

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.