GPX upload corrupt when using non-English locale

Bug #605174 reported by Ilya
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenSatNav
Fix Committed
High
evolvedlight

Bug Description

When the track is recoded and i hit 'submit to osm' it asks me for tags and I press 'ok'. The next message says the track was uploaded successfully. But if I go to my profile on OSM the track isn't there. Even after several hours.

Things to notice:
— The message saying the track was uploaded is displayed immediately, while the connection is rather slow(gprs).
— My login on OSM contains exclamation mark.

Tags: gsoc
Revision history for this message
evolvedlight (steve-evolvedlight) wrote :

This will be fixed by me very shortly!

Changed in opensatnav:
assignee: nobody → evolvedlight (steve-evolvedlight)
importance: Undecided → High
status: New → Confirmed
tags: added: gsoc
Revision history for this message
Murphy (murphy2712+launchpad) wrote :

Is it fixed?

Revision history for this message
chris_debian (cjhandrew) wrote :

This is fixed for me. Happy for this to be closed.

Chris.

Revision history for this message
Ilya (me-detected) wrote :

Tested in latest version of OpenSatNav and the bug seems to be there still. Got an e-mail from OSM:

--------------------------------------8<-----------------------------------------------------
Hi,

It looks like your GPX file

 20100921_204145_625_mylogin_.gpx

with the description

 test

and the following tags:

 OpenSatNav
 A5=BO1@O
 2010

failed to import. Here's the error:

 Found no good GPX points in the input data

More information about GPX import failures and how to avoid
them can be found at:

 http://wiki.openstreetmap.org/index.php/GPX_Import_Failures
--------------------------------------8<-----------------------------------------------------

Also I do not understand the strange tag 'A5=BO1@O'.

Revision history for this message
Kieran Fleming (kieran-fleming) wrote :

It should have the month instead of 'A5=BO1@O'. What language setting is your phone using?

Revision history for this message
Ilya (me-detected) wrote :

My phone locale is in Russian Русский(Россия)

Revision history for this message
Kieran Fleming (kieran-fleming) wrote :

OK, the bug happens when in Russian but not in English so for now the workaround is to switch the language. I thought it was something to do with the month name but even when that's disabled by passing false for addDateTags to uploadAsync it still fails. Steve, can you have a look at this?

Revision history for this message
Murphy (murphy2712+launchpad) wrote :

It looks like I have this problem with the french language too, but the month seems ok:
===
Hi,

It looks like your GPX file

 20101006_211609_445_Murphy.gpx

with the description

 osn track

and the following tags:

 OpenSatNav
 octobre
 2010

failed to import. Here's the error:

 Found no good GPX points in the input data
===
Changing to english language uploads fine.

Revision history for this message
Kieran Fleming (kieran-fleming) wrote :

Updated title to reflect what this bug has become! I think I'll leave this as a known issue for 1.0.

Changed in opensatnav:
milestone: none → 1.1
summary: - track is reported as 'uploaded', but actually not
+ GPX upload corrupt when using non-English locale
Revision history for this message
Ilya (me-detected) wrote :

As a temporary solution could OpenSatNav.org use local-unaware function in this case? It's very inconvenient to switch locales before starting OSNO and back after recording track.

Revision history for this message
Pontus Freyhult (pontusf) wrote :

I'm pretty certain we don't want GPX generation to vary with user locale. As there are also quite a few potential issues here, I think the smallest/easiest fix is to just pretend we're in the us.

(The supplied patch fixes what this issue seems to have become. There seems to be a few other problems with track submission that I'll try to investigate and write bugs for, from the top of my head those includes possible track truncation and lack of error message on bad credentials as well as a RFE to trim the username before submitting.)

Revision history for this message
Kieran Fleming (kieran-fleming) wrote :

Thanks Pontus, I've pushed your change up to trunk so there will be a new build shortly.

Changed in opensatnav:
status: Confirmed → Fix Committed
milestone: 1.1 → 1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.