Disaggregation calculator does not sample inside of the logic tree sample loop
Bug #888145 reported by
Lars Butler
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenQuake (deprecated) |
Fix Released
|
High
|
Lars Butler |
Bug Description
A simple oversight happened when the disagg calculator mixin was first coded. Basically, samples for the source model and gmpe logic trees are being stored BEFORE the realization/logic tree sample loop starts; this means that the results for each LT sample will be exactly the same!
The flow of the disagg calculator should follow the flow of the classical calculator; when we loop over realizations, we need to do fresh sampling of the src model and gmpe LTs.
Changed in openquake: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in openquake: | |
assignee: | nobody → Lars Butler (lars-butler) |
milestone: | none → 0.4.6 |
status: | Confirmed → In Progress |
Changed in openquake: | |
status: | In Progress → Fix Committed |
Changed in openquake: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
https:/ /github. com/gem/ openquake/ pull/574