fields set as readonly can receive focus in openerp6.1--web

[William Beltrán]

Fields set as readonly in form views can receive focus, I think if the field is readonly is not necesary to let it get focus, it is usefull in the moment to fill form and reduce time for users because you have not to pass throw fields that are inactive.

I am using openerp6.1 we client+firefox+ubuntu11.10.

Regards

[William Beltrán (wigebeno)]

I fix this bug, i edit the file:

/addons/web/static/src/js/view_form.js

in line 1467 i add this:

var disabled = (this.readonly || this.force_disabled || !this.view.is_interactible_record());
this.$element.find('input').prop('disabled', disabled);

just before:

this.$element.find('input').prop('readonly', this.readonly);

It will be important to include this in trunk i think what do you think??

[Amit Parik (amit-parik)]

Hello William,

You can purpose a merge proposal for this, So If you want to contribute then please create a branch and put a merge proposal for this. Our core team will review it.

Thanks you!

[William Beltrán (wigebeno)]

sure, I want to contribute, how can i do that?? How can create a mereg
proporsal or where can find information about this?

El 04/05/12 06:10, Amit Parik (OpenERP) escribió:
> Hello William,
>
> You can purpose a merge proposal for this, So If you want to contribute
> then please create a branch and put a merge proposal for this. Our core
> team will review it.
>
> Thanks you!
>

[Cristian Salamea (ovnicraft)]

Hello William, you can create a branch stacked over openerp-web project:

bzr branch lp:openerp-web this will create a branch (here make your changes) check how to commit e.g. to fix "[FIX] mi comment related" also check this[1] to link the related bug.

You can push the branch directly to Launchpad with the command:

bzr push lp:~wigebeno/openerp-web/openerp-web

So in your branch you get an opt to make the proposal and select the trunk.

Thanks for your fix.

Regards,

[William Beltrán (wigebeno)]

Hello, I check the code and i think works better whit this code:
var disabled = (this.readonly);
this.$element.find('input').prop('disabled', disabled);

instead:

var disabled = (this.readonly || this.force_disabled || !this.view.is_interactible_record());
this.$element.find('input').prop('disabled', disabled);

I also check the way of make a merge proporsal but in trunk i didnt find the function that I fix in 6.1 so i imagine that this part is not considered yet in trunk so I can't make a merge prporsal but works fine for 6.1.1.

Regards.