Does not check return value of pg_restore
Bug #879872 reported by
Stefan Rijnhart (Opener)
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Server (MOVED TO GITHUB) |
Confirmed
|
Wishlist
|
OpenERP's Framework R&D | ||
Bug Description
Hi,
When restoring a database through the interface, the server side code does not properly check the return value of the pg_restore process.
The process flags a non-empty stdout as error condition, but this is not appropriate. Errors are logged to stderr by pg_restore, as are warnings. Neither are of any use. The process should call wait() on the Popen object, and check on its return value which is the return value of pg_restore.
Reproducable on trunk, rev 3772.
Cheers,
Stefan.
Related branches
lp:~openerp-community/openobject-server/stefan-therp_lp879872-6.1
- Olivier Dony (Odoo): Needs Information
-
Diff: 50 lines (+9/-10)2 files modifiedopenerp/service/web_services.py (+8/-8)
openerp/tools/misc.py (+1/-2)
| Changed in openobject-server: | |
| assignee: | nobody → OpenERP's Framework R&D (openerp-dev-framework) |
| importance: | Undecided → Wishlist |
| status: | New → Confirmed |
To post a comment you must log in.
