Odoo Server (MOVED TO GITHUB)

audit trail - changes in o2m resources are NOT logged

Bug #832635 reported by Ferdinand
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Status tracked in Trunk
6.0
Won't Fix
Low
OpenERP Publisher's Warranty Team
Trunk
New
Low
OpenERP's Framework R&D

Bug Description

example
want to log changes in invoice lines
set a audit log for
* account_invoice
* account_invoice_line

changes of invoice lines produce
* an empty entry in account_invoice
* no entry for invoice_lines

Tags: maintenance

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-832635-nch
qdp (OpenERP): Needs Fixing
Antony Lesuisse (OpenERP): Pending requested
Vo Minh Thu: Pending requested
Olivier Dony (Odoo): Pending requested
Diff: 591 lines (+267/-240)
1 file modified
audittrail/audittrail.py (+267/-240)
Dhruti Shastri(OpenERP) (dhs-openerp)
Changed in openobject-server:
assignee: nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance: Undecided → Low
status: New → Confirmed
Vinay Rana (OpenERP) (vra-openerp)
Changed in openobject-server:
assignee: OpenERP's Framework R&D (openerp-dev-framework) → OpenERP Publisher's Warranty Team (openerp-opw)
tags: added: maintenance
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

The Audit trail module needs heavy refactoring. due to current code which makes many extra and unnecessary calls to db needs to re-factored to speed up logging. currently its very slow.

I would also assign the same to trunk version as major improvements will be in trunk

@ OPW: you can fix the bug for the stable version. The improvements has already started in trunk.

Thanks

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

Thanks for reporting !

The bug contains the fix in the merge proposal lp:~openerp-dev/openobject-addons/trunk-bug-832635-nch along with refactoring and improvements !

please provide your feedback !

Thanks,

Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

The complexity of the proposed fix makes it inadequate for the stable version.
It needs proper testing in the trunk before being released.

Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

I propose to keep the fix for the trunk, and not fix version 6.0.

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Raphael,

yes you are right ! It complex but it was really needed to refactore the whole module because it was vary badly coded. with many calls to database and much more... so the proposed branched indeed can be seen as "a fix + improvements + refactoring"

Thanks,

Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

Hello,

By taking reference from Raphael Collet comment #4 I am closing this issue for version 6.

Thanks.

Revision history for this message
qdp (OpenERP) (qdp) wrote :

merge proposal needs fixing

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

merge proposal improved please re review !

Revision history for this message
Antony Lesuisse (OpenERP) (al-openerp) wrote :

This has been fixed in 5754 revid:<email address hidden>

Revision history for this message
Ferdinand (office-chricar) wrote :

Please see comments here
https://answers.launchpad.net/openobject-addons/+question/247070

Revision history for this message
Ferdinand (office-chricar) wrote :

actually nothing is logged using demo data logging of partner
- and yes the rule is "subscribed" and openerp restarted (in case of)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.