bzr_set.py doesn't report locked branches

[Daniel Watkins (credativ)]

If the bzr_set.py script hits a locked branch, it just sits idle, without reporting this fact. This can be a real pain, and should be fixable.

[Olivier Dony (Odoo) (odo-openerp)]

Interesting improvement, keeping as wishlist for after v6.0.
Thanks for the suggestion!

[Dimitri John Ledkov (ex-credativ) (dle-credativ)]

Has this been considered for 6.1?

[Olivier Dony (Odoo) (odo-openerp)]

On 07/31/2011 10:11 PM, Dmitrijs Ledkovs (credativ) wrote:
> Has this been considered for 6.1?

No, but as this is a quite unrelated to core code, it could be improved
regardless of any release roadmap :-)

It might be a simple improvement, but a quick look at the bzrlib API did
not reveal anything to specify fail-fast locking for the bzr commands.
You would think that lock contention would always cause a timeout error,
similarly to what happens when you call these commands manually.

Maybe someone from the community would like to investigate further, and
perhaps provide clear steps to reproduce, or even a patch?

[Ana Juaristi Olalde (ajuaristio)]

Clear steps for reproduce:

1. Execute bzr_set.py
2. During execution, cut before finishing all branches.
3. The branche that is downloading on this moment stays locked. So next time
you execute bzr_setup you will have again the error.
5. manual solution: Go to de the downloading folder. Look for
.bzr/branch/lock and erase it.
Next time... if you execute bzr_set.py and all branches are downloaded,
problem is solved. If next time, error is shown again, it's better erasing
all .bzr/branch/lock subfolders located on all branches that you are
downloading, before starting script again.
It's a kind of little nighmare each time it happens.

Wishing this will give you a clue...

Thank you:

Ana

2011/8/6 Olivier Dony (OpenERP) <email address hidden>

> On 07/31/2011 10:11 PM, Dmitrijs Ledkovs (credativ) wrote:
> > Has this been considered for 6.1?
>
> No, but as this is a quite unrelated to core code, it could be improved
> regardless of any release roadmap :-)
>
> It might be a simple improvement, but a quick look at the bzrlib API did
> not reveal anything to specify fail-fast locking for the bzr commands.
> You would think that lock contention would always cause a timeout error,
> similarly to what happens when you call these commands manually.
>
> Maybe someone from the community would like to investigate further, and
> perhaps provide clear steps to reproduce, or even a patch?
>
> --
> You received this bug notification because you are a member of OpenERP
> CTP, which is subscribed to OpenERP Server.
> https://bugs.launchpad.net/bugs/637929
>
> Title:
> bzr_set.py doesn't report locked branches
>
> Status in OpenERP Server:
> Confirmed
>
> Bug description:
> If the bzr_set.py script hits a locked branch, it just sits idle,
> without reporting this fact. This can be a real pain, and should be
> fixable.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-server/+bug/637929/+subscriptions
>

--
Ana Juaristi Olalde <http://www.anajuaristi.com/>: Personal phone: [phone]
59. User/usuario skype: Avanzosc
CEO Avanzosc, S.L <http://www.avanzosc.com/> : Office phone / Tfono oficina:
([phone]
www.openerpsite.com