SQLAlchemy DbHandler doesn't comply to OpenERP coding conventions

[Raphaël Valyi - http://www.akretion.com]

Hi,

I'm actually talking here about the new server-sa branch, but since the bug tracker is set to here, reporting here.
Sorry if that's a harsh one, but the new DBHandler code doesn't comply to the OpenERP coding conventions.

For instance, I see that kind "Javahish" of method names (all over bin/dbhandler):

    def createColumn(self, cr, table, column, type):

    def dropColumn(self, cr, table, column):

    def renameTable(self, cr, old, new):

While pytonista OpenERP compliant naming conventions would be:

    def create_column(self, cr, table, column, type):

    def drop_column(self, cr, table, column):

    def rename_table(self, cr, old, new):

I think that important to actually conform to a single simple coding convention. Else you just confuse the community and you increase the chance contributed code is chaos too. Frankly OpenERP has done enough such lack of rigor errors in the past (like misspelling in column names or non consistent foreign key names) that are still lagging today increasing the entry barrier by confusing newcomers, that I think it's better to just adopt a consistent style before releasing the dbhandler interface and associated code.

Hope you do that move, unless you drop that code for the slqalchemy-migrate framework as reported in my next bug report.

Raphaël Valyi; now from Sao Paulo

[Mantavya Gajjar (Open ERP) (mga)]

Hello Raphaël Valyi,

Thanks for the suggestions, we change it according to the standards, also check for the complete dbhandler before releasing it

Thanks
mga

[Mantavya Gajjar (Open ERP) (mga)]

hello,

its fixed in to the same branch

Thanks for the supports