.bzrignore ignores all addons

[Leonardo Pistone]

observed in v6.1, v7, trunk

Hi.

In the .bzrignore file of openobject-server I find that too many files are ignored. In general, I expect "bzr status" to tell me that the tree is clean only when it is actually clean.

- openerp/addons/*

I consider that one to be a real bug for two reasons: first, it ignores proper, important python code (all of the base module). Second, if you add of symlink modules there (a bad practice probably, but nothing prevents you from doing that), they will be used without you noticing.

I would also take out more things, but that is up to discussion. In any case, here is a list of what I would take out too, without being so bad:

- .bzrignore. If some user wants to ignore more files, they should use their personal ignore file, not add things to a file that ignores itself.

- .swp : if I am editing a file, or the editor has crashed, or I forgot to save, I consider my tree unclean, and I do not want bzr to tell me it's all clean.

- bin/ include/ lib/ : these look like they are meant for a virtualenv created with "virtualenv ." which could be a bad idea. I might be wrong on that one though.

Thanks!

[Mohammad Alhashash (alhashash)]

From the documentation:
"Note that ignore patterns are only matched against non-versioned files, and control whether they are treated as “unknown” or “ignored”. If a file is explicitly added, it remains versioned regardless of whether it matches an ignore pattern."
http://doc.bazaar.canonical.com/bzr.2.6/en/user-guide/controlling_registration.html

So, base addons are tracked but new files has to be explicitly added ('bzr add' will not blindly add new files). I think it was made like this to allow copying or linking addons to the 'openerp/addons' folder and still using bzr to manage the server repository. I think in versions brefore 6.1 you could only have one addons folder.

[Mohammad Alhashash (alhashash)]

Base addons are tracked.

[Leonardo Pistone (lepistone)]

Thanks for your clarification Mohammad: I was in fact a bit too generic.

Still, I remain convinced that openerp/addons/* (and .bzrignore and *.swp) should not be ignored.

In general I would like to be able to trust my VCS when it says that the repository is clean.

Specifically, if you work with an old instance that, like you said, has all modules linked into server/openerp/addons, you do a "bzr status", read "all clean", then you're authorized to believe all _is_ clean.

If there is some issue with files that are linked or copied (wrong versions, broken links, etc), you could not notice immediately. That is exactly what happened to me today.

On the other hand, if you actually symlink your addons (but after 6.0, you probably shouldn't) it is a good thing that bzr tells you that there are uncommited symlinks lying around. You can commit them in a branch if you need to.

Thanks!

Leo