wrong xml escaping in pdf reports
Bug #1130010 reported by
Jacques-Etienne Baudoux
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo Server (MOVED TO GITHUB) |
New
|
Undecided
|
Unassigned |
Bug Description
All reports are calling the method toxml to escape the strings to be formatted in xml.
from report.interface import toxml
'<account id="%d" name="%s">' % (aid, toxml(aname)))
The toxml method is properly escaping the characters according to xml specifications as it escapes < > &
However, if the xml code is created manually with a format string, you need to also escape the " character into "
I suggest this correction in all pdf reports:
- from report.interface import toxml
+ import report.interface
+ toxml = lambda s: report.
Related branches
lp:~openerp-community/openobject-server/fix-1130010-toxml-escape-quot
Ready for review
for merging
into
lp:openobject-server
- OpenERP Core Team: Pending requested
-
Diff: 11 lines (+1/-1)1 file modifiedopenerp/report/interface.py (+1/-1)
affects: | openobject-addons → openobject-server |
To post a comment you must log in.