Avoid recursive OnChange event

[Yann Papouin]

In a custom module that I'm trying to develop, there are three fields with a OnChange event that affects each of the other fields.

The main issue is that the OnChange event is propagated threw all fields again and again until a balance is found (the value does not change, so the OnChange event is not triggered).

Is there a way to avoid the OnChange "butterfly effect" ?

I tried with a custom tag variable passed in the context dictionnary, but apparently this custom context is lost when exiting the OnChange event.

[Serpent Consulting Services (serpent-consulting-services)]

Yann,

I am sure you can handle this within your code.

By design, if value is changed (disregard to manual way or from the onchange of another field); onchange trigger has to fire.

What you can do here is call another onchange with special context and make specific adjustments.

You can also manage this by value based call to onchanges.

If you wish, you can share your example.

Thanks.

[Yann Papouin (yann-papouin)]

Hi,

I'm attaching the code currently used (a mix between sale_layout and sale_margin)

Please focus on:
onchange_price_unit
onchange_margin_percent
onchange_markup_percent

The fields that interact each other are:
price_unit
price_discount
margin
margin_percent
markup_percent

As you will see, I try to use a flag inside a context, but this value is only visible in this function context (even after multiple on change)
eg:context.update({'ignore_margin_update': True});

[Atul Makwana(SerpentCS) (amakwana-serpentcs)]

Hello Yann,

After reviewing your onchange methods, I have done following changes to avoid the OnChange "butterfly effect".

kindly apply the attached patch and notify us regarding the results.

Hope this will solve your issue.

Let me know if you still have issues.

Thanks
Atul Makwana
Serpent Consulting Services